Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373833003: Make WTF::Vector work with gmock matchers, refactor some tests to use it (Closed)

Created:
5 years, 2 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 2 months ago
Reviewers:
haraken, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-wtf_chromium.org, dglazkov+blink, eae+blinkwatch, Mikhail, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WTF::Vector work with gmock matchers, refactor some tests to use it There are some tests that used std::vector in blink, this patch makes them all use WTF::Vector instead BUG= Committed: https://crrev.com/802f2c6056cc2e12fccb3ae147d770afbd479ca1 Cr-Commit-Position: refs/heads/master@{#352226}

Patch Set 1 #

Patch Set 2 : Missed a couple #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 1 10 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 9 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373833003/1
5 years, 2 months ago (2015-10-01 17:21:35 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/126644) android_chromium_gn_compile_dbg on ...
5 years, 2 months ago (2015-10-01 17:49:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373833003/20001
5 years, 2 months ago (2015-10-02 10:02:23 UTC) #6
alex clarke (OOO till 29th)
5 years, 2 months ago (2015-10-02 10:54:56 UTC) #8
alex clarke (OOO till 29th)
haraken@chromium.org: Please review changes in wtf/Vector.h
5 years, 2 months ago (2015-10-02 10:57:41 UTC) #10
haraken
LGTM
5 years, 2 months ago (2015-10-02 11:03:57 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/76994)
5 years, 2 months ago (2015-10-02 12:40:34 UTC) #13
esprehn
lgtm
5 years, 2 months ago (2015-10-03 01:29:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373833003/20001
5 years, 2 months ago (2015-10-03 01:30:35 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-03 02:40:24 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 02:41:10 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/802f2c6056cc2e12fccb3ae147d770afbd479ca1
Cr-Commit-Position: refs/heads/master@{#352226}

Powered by Google App Engine
This is Rietveld 408576698