Files.app: add feedback animation to context menu.

Files.app: add feedback animation to context menu.

* Implemented FilesMenuItem which performs ripple animation when it's
  clicked.
* Removed root element animation from directory tree context menu and
  replaced with new feedback animation.

BUG=502171
TEST=manually tested

Committed: https://crrev.com/af5d33d821801fe72e23af8703c20e20c47bfb6d
Cr-Commit-Position: refs/heads/master@{#351711}

[yawano, 2015-09-29 08:57:52]

yawano@chromium.org changed reviewers:
+ fukino@chromium.org

[yawano, 2015-09-29 08:57:52]

PTAL. Thank you!

[fukino, 2015-09-30 07:26:07]

Thanks! I like the new effect.

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/css/menu.css (right):

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/css/menu.css:71: left: -25%;
nit: please add a comment for this hack to speed up ripple animation.

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/files_menu.js (right):

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/files_menu.js:22: * @private
{?boolean}
nit: Is it possible to have this {boolean|undefined}?
boolean is not an Object, so it would be more consistent with other annotations
than {boolean|null}

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/files_menu.js:166:
FilesMenuItemUtil.queryAndDecorate = function() {
Can we have this process in FileManager or FileManagerUI?
I think it'd be better if this file is only for cr.ui.FilesMenuItem and it is
independent from dom structure or current whole-app design spec (e.g. it should
work with menu item which doesn't have cr-menu/cr-menu-item class ||
cr.ui.FilesMenuItem should be able to apply to menu items partially).

[yawano, 2015-09-30 10:03:53]

Thank you for the review! PTAL.

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/css/menu.css (right):

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/css/menu.css:71: left: -25%;
On 2015/09/30 07:26:07, fukino wrote:
> nit: please add a comment for this hack to speed up ripple animation.

Done.

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/files_menu.js (right):

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/files_menu.js:22: * @private
{?boolean}
On 2015/09/30 07:26:07, fukino wrote:
> nit: Is it possible to have this {boolean|undefined}?
> boolean is not an Object, so it would be more consistent with other
annotations
> than {boolean|null}

Done.

https://codereview.chromium.org/1373793003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/files_menu.js:166:
FilesMenuItemUtil.queryAndDecorate = function() {
Yes, moved to file_manager_ui.js. Done.

[fukino, 2015-09-30 10:13:13]

lgtm. Thank you!

[yawano, 2015-10-01 02:17:24]

On 2015/09/30 10:13:13, fukino wrote:
> lgtm. Thank you!

Thank you!

[yawano, 2015-10-01 02:17:28]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2015-10-01 02:18:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373793003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373793003/60001

[commit-bot: I haz the power, 2015-10-01 02:44:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-01 02:45:19]

Patchset 4 (id:??) landed as
https://crrev.com/af5d33d821801fe72e23af8703c20e20c47bfb6d
Cr-Commit-Position: refs/heads/master@{#351711}