Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1373793002: Use version_info wrapper functions instead of macros. (Closed)

Created:
5 years, 2 months ago by sdefresne
Modified:
5 years, 2 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use version_info wrapper functions instead of macros. version_info components provides helper function to access the value of the PRODUCT_VERSION and IS_OFFICIAL_BUILD macros so use them instead of the macro directly. This remove a dependency on a generated header file that should be private to the version_info component. BUG=None Committed: https://crrev.com/0131ca248edfe6c594fa8a6e5780f55c0f4d01eb Cr-Commit-Position: refs/heads/master@{#351058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/metrics/net/version_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look.
5 years, 2 months ago (2015-09-28 09:15:39 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-28 11:36:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373793002/1
5 years, 2 months ago (2015-09-28 12:11:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 12:16:26 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 12:17:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0131ca248edfe6c594fa8a6e5780f55c0f4d01eb
Cr-Commit-Position: refs/heads/master@{#351058}

Powered by Google App Engine
This is Rietveld 408576698