Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373773002: Fix check-webkit-style errors in Source/wtf/text/. (Closed)

Created:
5 years, 2 months ago by tkent
Modified:
5 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, jshin+watch_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix check-webkit-style errors in Source/wtf/text/. This CL has no behavior changes. BUG= Committed: https://crrev.com/cb39e698dfeb676bc7145168589d52b3275fb911 Cr-Commit-Position: refs/heads/master@{#351051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -409 lines) Patch
M third_party/WebKit/Source/wtf/text/AtomicStringHash.h View 1 chunk +22 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/Base64.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/Collator.h View 1 chunk +22 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringBuilder.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringBuilder.cpp View 5 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringHash.h View 1 chunk +129 lines, -128 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 6 chunks +25 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodec.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecICU.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecICU.cpp View 6 chunks +19 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecLatin1.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUTF16.h View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp View 5 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUserDefined.h View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUserDefined.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextEncoding.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/UTF8.h View 1 chunk +31 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/UTF8.cpp View 8 chunks +75 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/Unicode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 9 chunks +54 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 15 chunks +38 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/icu/UnicodeIcu.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tkent
yosin@, would you review this low-priority CL please?
5 years, 2 months ago (2015-09-28 07:48:58 UTC) #2
yosin_UTC9
lgtm Thanks for cleanup!!
5 years, 2 months ago (2015-09-28 08:59:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373773002/1
5 years, 2 months ago (2015-09-28 09:17:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 10:25:13 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 10:26:04 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cb39e698dfeb676bc7145168589d52b3275fb911
Cr-Commit-Position: refs/heads/master@{#351051}

Powered by Google App Engine
This is Rietveld 408576698