Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small fix for mask Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
index 1fe4e1c3e4e3fcb387e92d72072cc62d040d4da4..024f30d4fd304a6c3a673f6d37e6024a0b2dff05 100644
--- a/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
@@ -104,7 +104,7 @@ namespace blink {
CSS{{animation}}Data& data = state.style()->access{{animation}}s();
data.{{vector}}.clear();
for (auto& listValue : toCSSValueList(*value))
- data.{{vector}}.append(CSSToStyleMap::mapAnimation{{attribute}}(listValue.get()));
+ data.{{vector}}.append(CSSToStyleMap::mapAnimation{{attribute}}(*listValue));
}
{% endmacro %}
{{apply_animation('CSSPropertyAnimationDelay', 'Delay', 'Animation')}}
@@ -236,13 +236,13 @@ static bool borderImageLengthMatchesAllSides(const BorderImageLengthBox& borderI
{
NinePieceImage image(state.style()->{{getter}}());
{% if modifier_type == 'Outset' %}
- image.setOutset(CSSToStyleMap::mapNinePieceImageQuad(state, value));
+ image.setOutset(CSSToStyleMap::mapNinePieceImageQuad(state, *value));
{% elif modifier_type == 'Repeat' %}
- CSSToStyleMap::mapNinePieceImageRepeat(state, value, image);
+ CSSToStyleMap::mapNinePieceImageRepeat(state, *value, image);
{% elif modifier_type == 'Slice' %}
- CSSToStyleMap::mapNinePieceImageSlice(state, value, image);
+ CSSToStyleMap::mapNinePieceImageSlice(state, *value, image);
{% elif modifier_type == 'Width' %}
- image.setBorderSlices(CSSToStyleMap::mapNinePieceImageQuad(state, value));
+ image.setBorderSlices(CSSToStyleMap::mapNinePieceImageQuad(state, *value));
{% endif %}
state.style()->{{setter}}(image);
}
@@ -406,12 +406,12 @@ static bool borderImageLengthMatchesAllSides(const BorderImageLengthBox& borderI
for (unsigned int i = 0; i < valueList->length(); i++) {
if (!currChild)
currChild = prevChild->ensureNext();
- CSSToStyleMap::{{map_fill}}(state, currChild, valueList->item(i));
+ CSSToStyleMap::{{map_fill}}(state, currChild, *valueList->item(i));
prevChild = currChild;
currChild = currChild->next();
}
} else {
- CSSToStyleMap::{{map_fill}}(state, currChild, value);
+ CSSToStyleMap::{{map_fill}}(state, currChild, *value);
currChild = currChild->next();
}
while (currChild) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698