Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1373743002: [crankshaft] Add support for %_ToString. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Add support for %_ToString. Also support %_ToString in Crankshaft utilizing the ToStringStub, which is also used in TurboFan and fullcodegen. This is necessary to repair a regression on Octane that was introduced when switching from the hand crafted NonStringToString/ToString magic to %_ToString (which properly supports @@toPrimitive). BUG=chromium:535953, v8:4307 LOG=n Committed: https://crrev.com/6266a9d6b576ab62e8b409d6fa0437a82b884d0d Cr-Commit-Position: refs/heads/master@{#30955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Jaro, Easy starter for the week - thanks to the HCallWithDescriptor :-). Please take ...
5 years, 2 months ago (2015-09-28 04:50:00 UTC) #1
Jarin
lgtm
5 years, 2 months ago (2015-09-28 04:52:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373743002/1
5 years, 2 months ago (2015-09-28 04:53:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 05:01:16 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 05:01:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6266a9d6b576ab62e8b409d6fa0437a82b884d0d
Cr-Commit-Position: refs/heads/master@{#30955}

Powered by Google App Engine
This is Rietveld 408576698