Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1373733002: Reland: Files.app: add create directory operation to context menu of directory tree. (Closed)

Created:
5 years, 2 months ago by yawano
Modified:
5 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Files.app: add create directory operation to context menu of directory tree. Original CL: > Files.app: add create directory operation to context menu of directory tree. > > Create directory operation is consisted with two operations, > 1. Create new directory with default name. > 2. Start rename operation of it. > > Since rename operation itself is already implemented with different CL, > this CL focuses on to create new directory with default name and update > the UI. > > BUG=502171 > TEST=browser_tests:DirectoryTreeContextMenu/FileManagerBrowserTest.Test/* > > Committed: https://crrev.com/57bd0537cd33f15039a9c6d929ce27f2515f8149 > Cr-Commit-Position: refs/heads/master@{#350522} patch from issue 1353753002 at patchset 40001 (http://crrev.com/1353753002#ps40001) Additional changes to the original CL: * Waits an element before starting to input text in test case. BUG=502171 TEST=run flaky test case 100 times; browser_tests:DirectoryTreeContextMenu/FileManagerBrowserTest.Test/18 Committed: https://crrev.com/2ea4d858f8e1b019aea2ef59d10b8efbcf0cda85 Cr-Commit-Position: refs/heads/master@{#351026}

Patch Set 1 #

Patch Set 2 : Fix flaky test cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -126 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 2 chunks +31 lines, -58 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 chunk +105 lines, -66 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 4 chunks +64 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js View 1 3 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 2 months ago (2015-09-28 04:23:05 UTC) #2
fukino
On 2015/09/28 04:23:05, yawano wrote: > PTAL. Thank you! lgtm. Please make sure this test ...
5 years, 2 months ago (2015-09-28 06:11:31 UTC) #3
yawano
On 2015/09/28 06:11:31, fukino wrote: > On 2015/09/28 04:23:05, yawano wrote: > > PTAL. Thank ...
5 years, 2 months ago (2015-09-28 06:37:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373733002/20001
5 years, 2 months ago (2015-09-28 06:38:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 06:43:11 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 06:43:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ea4d858f8e1b019aea2ef59d10b8efbcf0cda85
Cr-Commit-Position: refs/heads/master@{#351026}

Powered by Google App Engine
This is Rietveld 408576698