Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: build/config/android/internal_rules.gni

Issue 1373723003: Fix javac --incremental by using jmake for dependency analysis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aidl
Patch Set: fix license check Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/config.gni ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index 0a8f64dfbf0853e9d70ae4d2a6c10ea31e96314b..f9cdaf2d781b02e67bbd20340c725f96a45e8ba6 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -199,7 +199,7 @@ template("dex") {
rebased_output,
]
- if (incremental_dx) {
+ if (enable_incremental_dx) {
args += [ "--incremental" ]
}
@@ -1048,6 +1048,11 @@ template("compile_java") {
_enable_errorprone = invoker.enable_errorprone
}
+ _enable_incremental_javac = enable_incremental_javac
+ if (defined(invoker.enable_incremental_javac)) {
+ _enable_incremental_javac = invoker.enable_incremental_javac
+ }
+
_manifest_entries = []
if (defined(invoker.manifest_entries)) {
_manifest_entries = invoker.manifest_entries
@@ -1107,8 +1112,10 @@ template("compile_java") {
"--java-srcjars=@FileArg($_rebased_build_config:javac:srcjars)",
"--jar-excluded-classes=$_jar_excluded_patterns",
]
- if (incremental_javac) {
+ if (_enable_incremental_javac) {
args += [ "--incremental" ]
+ deps += [ "//third_party/jmake" ]
+ outputs += [ "${_intermediate_jar_path}.pdb" ]
}
if (_supports_android) {
deps += [ "//build/android:android_ijar" ]
@@ -1276,6 +1283,7 @@ template("java_library_impl") {
[
"dist_jar_path",
"enable_errorprone",
+ "enable_incremental_javac",
"jar_excluded_patterns",
"manifest_entries",
"proguard_config",
« no previous file with comments | « build/config/android/config.gni ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698