Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1373713004: Clean up the deprecation warning for Request.context (Closed)

Created:
5 years, 2 months ago by hiroshige
Modified:
5 years ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up the deprecation warning for Request.context Request.context is already removed in M46 and thus the deprecation message string is no longer needed. BUG=515786 Committed: https://crrev.com/53588a7c8556f13b3c8156e5b9e12339408035bc Cr-Commit-Position: refs/heads/master@{#361254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373713004/1
5 years, 2 months ago (2015-09-29 05:58:28 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/126750)
5 years, 2 months ago (2015-09-29 06:24:22 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373713004/1
5 years, 1 month ago (2015-10-28 11:53:53 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/132412)
5 years, 1 month ago (2015-10-28 12:56:46 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373713004/1
5 years, 1 month ago (2015-11-09 18:07:14 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-09 20:37:07 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373713004/1
5 years, 1 month ago (2015-11-23 19:04:10 UTC) #14
hiroshige
PTAL as a core/ owner. This is partial revert of https://codereview.chromium.org/1287273002/.
5 years, 1 month ago (2015-11-23 19:41:02 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-23 20:39:04 UTC) #18
kinuko
lgtm
5 years ago (2015-11-24 01:36:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373713004/1
5 years ago (2015-11-24 04:36:17 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 04:42:22 UTC) #22
commit-bot: I haz the power
5 years ago (2015-11-24 04:42:52 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53588a7c8556f13b3c8156e5b9e12339408035bc
Cr-Commit-Position: refs/heads/master@{#361254}

Powered by Google App Engine
This is Rietveld 408576698