Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373693002: Move ServiceWorker public headers to public/{web,platform}/modules/serviceworker (3/3) (Closed)

Created:
5 years, 2 months ago by kinuko
Modified:
5 years, 2 months ago
Reviewers:
tkent, falken
CC:
blink-reviews, chromium-reviews, dglazkov+blink, falken, gavinp+loader_chromium.org, horo+watch_chromium.org, Nate Chapin, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tyoshino+watch_chromium.org, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ServiceWorker public headers to public/{web,platform}/modules/serviceworker (3/3) Three-sided patch: [1] (blink) https://codereview.chromium.org/1262943002/ [2] (chromium) https://codereview.chromium.org/1254023006/ [3] (blink) THIS PATCH (Re-upload for: https://codereview.chromium.org/1262603004/) BUG=453032 Committed: https://crrev.com/6a2cacbf351282ffb09eb5b1ff2c4a2d1865a27a Cr-Commit-Position: refs/heads/master@{#351992}

Patch Set 1 #

Patch Set 2 : foo #

Patch Set 3 : #

Patch Set 4 : fix #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -384 lines) Patch
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/Cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/Cache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheStorage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheStorageError.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheStorageError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/RequestTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/ResponseTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerProviderClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorker.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerCache.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerCacheError.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerCacheStorage.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerClientQueryOptions.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerClientType.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerClientsClaimCallbacks.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerClientsInfo.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerError.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerEventResult.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerProvider.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerProviderClient.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerProxy.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerRegistration.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerRegistrationProxy.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerRequest.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerResponse.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerResponseError.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerResponseType.h View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerSkipWaitingCallbacks.h View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebServiceWorkerState.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerClientQueryOptions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/public/web/WebServiceWorkerContextClient.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/public/web/WebServiceWorkerContextProxy.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/public/web/WebServiceWorkerNetworkProvider.h View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 42 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373693002/1
5 years, 2 months ago (2015-09-26 16:57:49 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104109)
5 years, 2 months ago (2015-09-26 17:06:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373693002/20001
5 years, 2 months ago (2015-09-27 01:19:25 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104116) linux_chromium_compile_dbg_32_ng on ...
5 years, 2 months ago (2015-09-27 01:22:42 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373693002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373693002/40001
5 years, 2 months ago (2015-09-27 01:29:29 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104117)
5 years, 2 months ago (2015-09-27 01:38:17 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373693002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373693002/60001
5 years, 2 months ago (2015-09-27 13:45:55 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104133)
5 years, 2 months ago (2015-09-27 13:54:19 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373693002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373693002/80001
5 years, 2 months ago (2015-09-27 17:36:57 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/86780)
5 years, 2 months ago (2015-09-27 17:45:49 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373693002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373693002/100001
5 years, 2 months ago (2015-09-27 17:47:24 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104138)
5 years, 2 months ago (2015-09-27 17:56:12 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373693002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373693002/120001
5 years, 2 months ago (2015-09-28 15:15:51 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/109603)
5 years, 2 months ago (2015-09-28 17:13:02 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373693002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373693002/140001
5 years, 2 months ago (2015-10-01 13:44:33 UTC) #32
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 15:02:15 UTC) #36
kinuko
Ok now this seems to build. (This is re-upload of https://codereview.chromium.org/1262603004/) tkent-san, would you take ...
5 years, 2 months ago (2015-10-02 09:13:23 UTC) #37
tkent
lgtm
5 years, 2 months ago (2015-10-02 09:14:30 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373693002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373693002/140001
5 years, 2 months ago (2015-10-02 09:35:53 UTC) #40
commit-bot: I haz the power
Committed patchset #5 (id:140001)
5 years, 2 months ago (2015-10-02 09:42:53 UTC) #41
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 09:43:34 UTC) #42
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/6a2cacbf351282ffb09eb5b1ff2c4a2d1865a27a
Cr-Commit-Position: refs/heads/master@{#351992}

Powered by Google App Engine
This is Rietveld 408576698