Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1373633002: Remove --harmony-arrow-functions flag (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
wingo, aperez, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --harmony-arrow-functions flag Arrow functions have been enabled by default since the 4.5 branch. Committed: https://crrev.com/163419e8fa20b5a6730f874ccdb092ef51739600 Cr-Commit-Position: refs/heads/master@{#31031}

Patch Set 1 : Move tests from harmony to es6 #

Patch Set 2 : Fix message tests #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -725 lines) Patch
M src/bootstrapper.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/preparser.h View 1 2 3 4 chunks +1 line, -4 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 36 chunks +28 lines, -79 lines 0 comments Download
M test/cctest/test-typing-reset.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M test/message/arrow-bare-rest-param.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-formal-parameters.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/message/arrow-formal-parameters.out View 1 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-missing.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-param-after-rest.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-param-after-rest-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-strict-eval-bare-parameter.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/message/arrow-strict-eval-bare-parameter.out View 1 1 chunk +1 line, -1 line 0 comments Download
M test/message/arrow-two-rest-params.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/invalid-spread.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/invalid-spread-2.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/arrow-functions.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/arrow-functions-lexical-arguments.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/arrow-functions-this.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/object-literals-super.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-3501.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-4056.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-4160.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-arrow-duplicate-params.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-crbug-465671.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-crbug-465671-null.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/arrow-functions.js View 1 chunk +0 lines, -72 lines 0 comments Download
M test/mjsunit/harmony/arrow-functions-lexical-arguments.js View 1 chunk +0 lines, -158 lines 0 comments Download
M test/mjsunit/harmony/arrow-functions-this.js View 1 chunk +0 lines, -81 lines 0 comments Download
M test/mjsunit/harmony/arrow-rest-params.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/arrow-rest-params-lazy-parsing.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/default-parameters.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring-parameters-literalcount.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring-parameters-literalcount-nolazy.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/new-target.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/object-literals-super.js View 1 chunk +0 lines, -182 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-3501.js View 1 chunk +0 lines, -11 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-4056.js View 1 chunk +0 lines, -12 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-4160.js View 1 chunk +0 lines, -29 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-4211.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-508074.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-arrow-duplicate-params.js View 1 chunk +0 lines, -7 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-crbug-465671.js View 1 chunk +0 lines, -16 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-crbug-465671-null.js View 1 chunk +0 lines, -16 lines 0 comments Download
M test/mjsunit/harmony/rest-params-lazy-parsing.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/super.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/classes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/declaration-after-use.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/destructuring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/function-arity.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/literals.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/mutually-recursive-classes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/undefined.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/this-dynamic-lookup.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
adamk
5 years, 2 months ago (2015-09-25 22:01:01 UTC) #3
aperez
On 2015/09/25 22:01:01, adamk wrote: LGTM (non-owner review).
5 years, 2 months ago (2015-09-26 16:56:03 UTC) #4
aperez
On 2015/09/26 16:56:03, aperez wrote: > On 2015/09/25 22:01:01, adamk wrote: > > LGTM (non-owner ...
5 years, 2 months ago (2015-09-26 17:06:28 UTC) #5
adamk
On 2015/09/26 17:06:28, aperez wrote: > On 2015/09/26 16:56:03, aperez wrote: > > On 2015/09/25 ...
5 years, 2 months ago (2015-09-28 18:26:42 UTC) #6
adamk
rossberg, ping
5 years, 2 months ago (2015-09-30 00:31:44 UTC) #7
rossberg
lgtm
5 years, 2 months ago (2015-09-30 13:33:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373633002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373633002/80001
5 years, 2 months ago (2015-09-30 19:23:52 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 2 months ago (2015-09-30 19:49:55 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 19:50:48 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/163419e8fa20b5a6730f874ccdb092ef51739600
Cr-Commit-Position: refs/heads/master@{#31031}

Powered by Google App Engine
This is Rietveld 408576698