Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373573003: [Sync] Componentize AutofillWalletDataTypeController. (Closed)

Created:
5 years, 2 months ago by maxbogue
Modified:
5 years, 2 months ago
CC:
chromium-reviews, tim+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, zea+watch_chromium.org, bondd+autofillwatch_chromium.org, rouslan+autofill_chromium.org, blundell+watchlist_chromium.org, maxbogue+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Componentize AutofillWalletDataTypeController. BUG=511283 Committed: https://crrev.com/6aeb9079dc29b497ba993535b73b3a4235a4f7a5 Cr-Commit-Position: refs/heads/master@{#352680}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix build deps. #

Patch Set 4 : Move to the autofill component. #

Patch Set 5 : Missing gyp dep. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -260 lines) Patch
D chrome/browser/sync/glue/autofill_wallet_data_type_controller.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/sync/glue/autofill_wallet_data_type_controller.cc View 1 chunk +0 lines, -158 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 3 4 chunks +9 lines, -3 lines 1 comment Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill.gypi View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + components/autofill/core/browser/autofill_wallet_data_type_controller.h View 1 2 3 4 chunks +12 lines, -3 lines 0 comments Download
A + components/autofill/core/browser/autofill_wallet_data_type_controller.cc View 1 2 3 6 chunks +28 lines, -34 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
maxbogue
Nicolas, PTAL.
5 years, 2 months ago (2015-09-28 21:25:08 UTC) #2
Nicolas Zea
lgtm
5 years, 2 months ago (2015-09-29 00:02:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373573003/1
5 years, 2 months ago (2015-09-29 00:10:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104519)
5 years, 2 months ago (2015-09-29 00:21:01 UTC) #7
maxbogue
+estade for the DEPS change.
5 years, 2 months ago (2015-09-29 00:37:01 UTC) #9
Evan Stade
lgtm
5 years, 2 months ago (2015-09-29 17:25:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373573003/1
5 years, 2 months ago (2015-09-29 18:24:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/10459)
5 years, 2 months ago (2015-09-29 18:34:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373573003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373573003/20001
5 years, 2 months ago (2015-09-30 15:58:49 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/10918)
5 years, 2 months ago (2015-09-30 16:12:00 UTC) #19
maxbogue
Nicolas and Evan, please take another look at this CL. I've moved the controller to ...
5 years, 2 months ago (2015-10-06 02:18:55 UTC) #20
Nicolas Zea
lgtm
5 years, 2 months ago (2015-10-06 19:25:03 UTC) #21
Evan Stade
lgtm
5 years, 2 months ago (2015-10-06 20:32:52 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373573003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373573003/80001
5 years, 2 months ago (2015-10-06 20:34:55 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-06 20:53:07 UTC) #25
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/6aeb9079dc29b497ba993535b73b3a4235a4f7a5 Cr-Commit-Position: refs/heads/master@{#352680}
5 years, 2 months ago (2015-10-06 20:54:31 UTC) #26
please use gerrit instead
5 years, 2 months ago (2015-10-07 20:17:52 UTC) #28
Message was sent while issue was closed. 
https://codereview.chromium.org/1373573003/diff/80001/chrome/browser/sync/pro...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/1373573003/diff/80001/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_components_factory_impl.cc:205:
syncer::AUTOFILL_WALLET_DATA));
Oops, this should really be syncer::AUTOFILL_WALLET_METADATA, not
syncer::AUTOFILL_WALLET_DATA :-D

No worries, I am fixing it.

Powered by Google App Engine
This is Rietveld 408576698