Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5134)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1373573002: ABANDONED: OOPIFs: Moving stitching of local paths from renderer to browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-recursive-begone
Patch Set: Self-review. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/download/save_item.h » ('j') | content/browser/download/save_package.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index 4412c35d8526bc6621dd2785174d07275e877dd1..c74b4b28679d411e79bd510da8be6c5fb73eb746 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -801,13 +801,7 @@ class SavePageSitePerProcessBrowserTest : public SavePageBrowserTest {
protected:
void SetUpCommandLine(base::CommandLine* command_line) override {
SavePageBrowserTest::SetUpCommandLine(command_line);
-
- // TODO(lukasza): Enable --site-per-process once crbug.com/526786 is fixed.
- // (currently, when the line below is uncommented out, the test crashes
- // under blink::WebLocalFrameImpl::fromFrameOwnerElement called from
- // blink::WebPageSerializerImpl::openTagToString).
- //
- // content::IsolateAllSitesForTesting(command_line);
+ content::IsolateAllSitesForTesting(command_line);
}
void SetUpOnMainThread() override {
@@ -825,12 +819,6 @@ class SavePageSitePerProcessBrowserTest : public SavePageBrowserTest {
// Test for crbug.com/526786. Without OOPIFs fixes, the test will trigger
// a crash in the renderer process.
IN_PROC_BROWSER_TEST_F(SavePageSitePerProcessBrowserTest, SaveCrossSitePage) {
- // TODO(lukasza): Remove this check once crbug.com/526786 is fixed.
- if (content::AreAllSitesIsolatedForTesting()) {
- LOG(WARNING) << "Skipping the test.";
- return; // Avoid failing on Site Isolation FYI bot.
- }
-
GURL url(embedded_test_server()->GetURL(
"a.com", "/frame_tree/page_with_two_frames_remote_and_local.html"));
ui_test_utils::NavigateToURL(browser(), url);
« no previous file with comments | « no previous file | content/browser/download/save_item.h » ('j') | content/browser/download/save_package.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698