Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Unified Diff: content/common/frame_messages.h

Issue 1373573002: ABANDONED: OOPIFs: Moving stitching of local paths from renderer to browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-recursive-begone
Patch Set: Removed no longer needed WebKit dependency. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 468dffccc0d55ee8e9737e0608ed0d786339a045..53b0a6f7cf86af8d45946b8a649ca199a47575d4 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -671,12 +671,9 @@ IPC_MESSAGE_ROUTED4(FrameMsg_FailedNavigation,
// Note: this covers only the immediate frame / doesn't cover subframes.
IPC_MESSAGE_ROUTED0(FrameMsg_GetSavableResourceLinks)
-// Get html data by serializing the target frame and replacing all resource
-// links with a path to the local copy passed in the message payload.
-IPC_MESSAGE_ROUTED3(FrameMsg_GetSerializedHtmlWithLocalLinks,
- std::vector<GURL> /* urls that have local copy */,
- std::vector<base::FilePath> /* paths of local copy */,
- base::FilePath /* local directory path */)
+// Serialize the target frame into raw html/data fragments interspersed
+// with "blanks" which the browser will replace with local paths.
+IPC_MESSAGE_ROUTED0(FrameMsg_GetSerializedHtmlWithLocalLinks);
#if defined(ENABLE_PLUGINS)
// Notifies the renderer of updates to the Plugin Power Saver origin whitelist.
@@ -1174,11 +1171,27 @@ IPC_MESSAGE_ROUTED3(FrameHostMsg_SavableResourceLinksResponse,
// errors gathering the links.
IPC_MESSAGE_ROUTED0(FrameHostMsg_SavableResourceLinksError)
-// Response to FrameMsg_GetSerializedHtmlWithLocalLinks.
-IPC_MESSAGE_ROUTED3(FrameHostMsg_SerializedHtmlWithLocalLinksResponse,
- GURL /* frame URL */,
- std::string /* data buffer */,
- int32 /* complete status */)
+// Response to FrameMsg_GetSerializedHtmlWithLocalLinks (1).
+// Browser should append the data to the file where the frame is being saved.
+IPC_MESSAGE_ROUTED1(FrameHostMsg_SerializedHtmlFragment,
+ std::string /* data buffer */);
+
+// Response to FrameMsg_GetSerializedHtmlWithLocalLinks (2).
+// Browser should find the local path corresponding to the subframe
+// and append it to the file where the frame is being saved.
+IPC_MESSAGE_ROUTED1(FrameHostMsg_SerializedLocalPathForSubFrame,
ncarter (slow) 2015/10/08 20:57:55 I think ChildFrame is a better term than SubFrame
Łukasz Anforowicz 2015/10/09 16:54:08 Done. (FWIW I assume only frame_messages.h (+fall
+ int /* RenderFrame's or RenderFrameProxy's routing id
+ for the subframe we need a local path for. */);
+
+// Response to FrameMsg_GetSerializedHtmlWithLocalLinks (3).
+// Browser should find the local path corresponding to the savable
+// resource and append it to the file where the frame is being saved.
+IPC_MESSAGE_ROUTED1(FrameHostMsg_SerializedLocalPathForSavableResource,
+ GURL /* savable resource link */);
+
+// Response to FrameMsg_GetSerializedHtmlWithLocalLinks (4).
+// Browser should close the file where the frame is being saved.
+IPC_MESSAGE_ROUTED0(FrameHostMsg_SerializedEndOfFrame)
// Sent when the renderer updates hint for importance of a tab.
IPC_MESSAGE_ROUTED1(FrameHostMsg_UpdatePageImportanceSignals,

Powered by Google App Engine
This is Rietveld 408576698