ABANDONED: OOPIFs: Moving stitching of local paths from renderer to browser process.

chrome/browser/download/save_page_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
@@ skipping 786 matching lines @@
   EXPECT_TRUE(base::PathExists(full_file_name));
 }
 
 class SavePageSitePerProcessBrowserTest : public SavePageBrowserTest {
  public:
   SavePageSitePerProcessBrowserTest() {}
 
  protected:
   void SetUpCommandLine(base::CommandLine* command_line) override {
     SavePageBrowserTest::SetUpCommandLine(command_line);
-
-    // TODO(lukasza): Enable --site-per-process once crbug.com/526786 is fixed.
-    // (currently, when the line below is uncommented out, the test crashes
-    // under blink::WebLocalFrameImpl::fromFrameOwnerElement called from
-    // blink::WebPageSerializerImpl::openTagToString).
-    //
-    // content::IsolateAllSitesForTesting(command_line);
+    content::IsolateAllSitesForTesting(command_line);
   }
 
   void SetUpOnMainThread() override {
     SavePageBrowserTest::SetUpOnMainThread();
 
     host_resolver()->AddRule("*", "127.0.0.1");
     ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
     content::SetupCrossSiteRedirector(embedded_test_server());
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SavePageSitePerProcessBrowserTest);
 };
 
 // Test for crbug.com/526786.  Without OOPIFs fixes, the test will trigger
 // a crash in the renderer process.
 IN_PROC_BROWSER_TEST_F(SavePageSitePerProcessBrowserTest, SaveCrossSitePage) {
-  // TODO(lukasza): Remove this check once crbug.com/526786 is fixed.
-  if (content::AreAllSitesIsolatedForTesting()) {
-    LOG(WARNING) << "Skipping the test.";
-    return;  // Avoid failing on Site Isolation FYI bot.
-  }
-
   GURL url(embedded_test_server()->GetURL("a.com", "/save_page/iframes.htm"));
   ui_test_utils::NavigateToURL(browser(), url);
 
   base::FilePath full_file_name, dir;
   SaveCurrentTab(url, content::SAVE_PAGE_TYPE_AS_COMPLETE_HTML, "iframes", 5,
                  &dir, &full_file_name);
   ASSERT_FALSE(HasFailure());
 
   EXPECT_TRUE(base::DirectoryExists(dir));
   base::FilePath expected_files[] = {
@@ skipping 11 matching lines @@
     EXPECT_NE(0, actual_file_size) << "Is " << file_path.value()
                                    << " non-empty?";
   }
 
   // Verify that local links got correctly replaced with local paths
   // (most importantly for iframe elements, which are only exercised
   // by this particular test).
   std::string main_contents;
   ASSERT_TRUE(base::ReadFileToString(full_file_name, &main_contents));
   EXPECT_THAT(main_contents,
-              HasSubstr("<iframe src=\"./iframes_files/a.html\"></iframe>"));
+              HasSubstr("<iframe src=\"iframes_files/a.html\"></iframe>"));
   EXPECT_THAT(main_contents,
-              HasSubstr("<iframe src=\"./iframes_files/b.html\"></iframe>"));
-  EXPECT_THAT(main_contents,
-              HasSubstr("<img src=\"./iframes_files/1.png\">"));
+              HasSubstr("<iframe src=\"iframes_files/b.html\"></iframe>"));
+  EXPECT_THAT(main_contents, HasSubstr("<img src=\"iframes_files/1.png\">"));
 }
 
 }  // namespace