ABANDONED: OOPIFs: Moving stitching of local paths from renderer to browser process.

third_party/WebKit/Source/web/WebPageSerializerImpl.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 52 matching lines @@
     // Do serialization action.
     //
     // Returns false to indicate that no data has been serialized (i.e. because
     // the target frame didn't have a valid url).
     //
     // Synchronously calls WebPageSerializerClient methods to report
     // serialization results.  See WebPageSerializerClient comments for more
     // details.
     bool serialize();
 
-    // The parameter specifies which frame need to be serialized.
-    // The parameter delegate specifies the pointer of interface
-    // DomSerializerDelegate provide sink interface which can receive the
+    // The first parameter specifies which frame need to be serialized.
+    // The second parameter provides a sink interface which can receive the
     // individual chunks of data to be saved.
-    // The parameter links contain original URLs of all saved links.
-    // The parameter local_paths contain corresponding local file paths of all
-    // saved links, which matched with vector:links one by one.
-    // The parameter local_directory_name is relative path of directory which
-    // contain all saved auxiliary files included all sub frames and resources.
-    WebPageSerializerImpl(WebFrame* frame,
-                          WebPageSerializerClient* client,
-                          const WebVector<WebURL>& links,
-                          const WebVector<WebString>& localPaths,
-                          const WebString& localDirectoryName);
+    WebPageSerializerImpl(WebFrame*, WebPageSerializerClient*);

[ncarter (slow), 2015/10/08 20:57:55]

Why drop the parameter names -- is that just The Blink Way? 

blink code is outside of my stylistic expertise, but to my chromium-colored
eyes, it seems like removing the parameter names and having the comments refer
to the params by position makes this harder to understand than before.

[Łukasz Anforowicz, 2015/10/09 16:54:08]

Yes - this is blink-ism.  The error method from presubmit checks is:

** Presubmit ERRORS **
check-webkit-style failed
third_party/WebKit/Source/web/WebPageSerializerImpl.h:76:  The parameter name
"client" adds no information, so it should be removed. 
[readability/parameter_name] [5]

Yes - I also find documentation comments in blink world weird, when they cannot
use parameter names when documenting them.  Maybe something worth raising on
chromium-dev?

[dcheng, 2015/10/09 16:59:33]

Usually, we don't document parameters by position. I'd just update this comment
to say:
Creates a serializer to serialize the given frame, sending the data to a client
sink interface to consume.

[Łukasz Anforowicz, 2015/10/21 22:50:34]

Done.

 
 private:
     // Specified frame which need to be serialized;
     RawPtrWillBeMember<WebLocalFrameImpl> m_specifiedWebLocalFrameImpl;
     // Pointer of WebPageSerializerClient
     WebPageSerializerClient* m_client;
-    // This hash map is used to map resource URL of original link to its local
-    // file path.
-    typedef HashMap<WTF::String, WTF::String> LinkLocalPathMap;
-    // local_links_ include all pair of local resource path and corresponding
-    // original link.
-    LinkLocalPathMap m_localLinks;
     // Data buffer for saving result of serialized DOM data.
     StringBuilder m_dataBuffer;
-    // Local directory name of all local resource files.
-    WTF::String m_localDirectoryName;
 
     // Web entities conversion maps.
     WebEntities m_htmlEntities;
     WebEntities m_xmlEntities;
 
     class SerializeDomParam {
         STACK_ALLOCATED();
     public:
-        SerializeDomParam(const KURL&, const WTF::TextEncoding&, Document*, const WTF::String& directoryName);
+        SerializeDomParam(const KURL&, const WTF::TextEncoding&, Document*);
 
         const KURL& url;
         const WTF::TextEncoding& textEncoding;
         RawPtrWillBeMember<Document> document;
-        const WTF::String& directoryName;
         bool isHTMLDocument; // document.isHTMLDocument()
         bool haveSeenDocType;
         bool haveAddedCharsetDeclaration;
         // This meta element need to be skipped when serializing DOM.
         RawPtrWillBeMember<const Element> skipMetaElement;
         // Flag indicates we are in script or style tag.
         bool isInScriptOrStyleTag;
         bool haveAddedXMLProcessingDirective;
         // Flag indicates whether we have added additional contents before end tag.
         // This flag will be re-assigned in each call of function
@@ skipping 25 matching lines @@
     void saveHTMLContentToBuffer(const WTF::String& content,
                                  SerializeDomParam* param);
 
     enum FlushOption {
         ForceFlush,
         DoNotForceFlush,
     };
 
     // Flushes the content buffer by encoding and sending the content to the
     // WebPageSerializerClient. Content is not flushed if the buffer is not full
-    // unless force is 1.
-    void encodeAndFlushBuffer(WebPageSerializerClient::PageSerializationStatus status,
-                              SerializeDomParam* param,
-                              FlushOption);
+    // unless FlushOption::ForceFlush is used.
+    void encodeAndFlushBuffer(SerializeDomParam*, FlushOption);
     // Serialize open tag of an specified element.
-    void openTagToString(Element*,
-                         SerializeDomParam* param);
+    void handleOpenTag(Element*, SerializeDomParam*);
+    // Serialize value of URL-containing attribute of the specified element.
+    void handleLinkAttr(Element*, SerializeDomParam*, const String& attrValue);
     // Serialize end tag of an specified element.
-    void endTagToString(Element*,
-                        SerializeDomParam* param);
+    void handleEndTag(Element*, SerializeDomParam*);
     // Build content for a specified node
     void buildContentForNode(Node*,
                              SerializeDomParam* param);
 };
 
 } // namespace blink
 
 #endif