Chromium Code Reviews
DescriptionRevert of [NaCl SDK] nacl_io: Add support for basic socketpairs. (patchset #5 id:80001 of https://codereview.chromium.org/1335783005/ )
Reason for revert:
undefined reference to 'nacl_io::UnixNode::UnixNode(nacl_io::Filesystem*, nacl_io::UnixNode const&)'
Original issue's description:
> [NaCl SDK] nacl_io: Add support for basic socketpairs.
>
> This is a very basic implementation of a unix socketpair. The socket
> nodes have type S_IFSOCK.
>
> The event emitter are set up in a master/slave configuration, the master
> owns the fifos and slave handles. The slave has a strong reference to
> its master (since it depends on it, cannot survive alone). Each emitter
> in the pair has their own status, but share the pair of fifos and use a
> single lock in the master to synchronize their access.
>
> Shutdown should be rather simple to bolt on to this implementation.
>
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk
> BUG=532095
>
> Committed: https://crrev.com/e40c14e14250a5b3ea235ae0ec846b84d2be73ae
> Cr-Commit-Position: refs/heads/master@{#350849}
TBR=binji@chromium.org,bradnelson@chromium.org,sbc@chromium.org,avallee@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=532095
Committed: https://crrev.com/cdc76669194bd2f0402155f4a2da9905bbe3f81a
Cr-Commit-Position: refs/heads/master@{#350865}
Patch Set 1 #Messages
Total messages: 8 (0 generated)
|