Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1373563003: Revert of [NaCl SDK] nacl_io: Add support for basic socketpairs. (Closed)

Created:
5 years, 2 months ago by cmumford
Modified:
5 years, 2 months ago
CC:
binji+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [NaCl SDK] nacl_io: Add support for basic socketpairs. (patchset #5 id:80001 of https://codereview.chromium.org/1335783005/ ) Reason for revert: undefined reference to 'nacl_io::UnixNode::UnixNode(nacl_io::Filesystem*, nacl_io::UnixNode const&)' Original issue's description: > [NaCl SDK] nacl_io: Add support for basic socketpairs. > > This is a very basic implementation of a unix socketpair. The socket > nodes have type S_IFSOCK. > > The event emitter are set up in a master/slave configuration, the master > owns the fifos and slave handles. The slave has a strong reference to > its master (since it depends on it, cannot survive alone). Each emitter > in the pair has their own status, but share the pair of fifos and use a > single lock in the master to synchronize their access. > > Shutdown should be rather simple to bolt on to this implementation. > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk > BUG=532095 > > Committed: https://crrev.com/e40c14e14250a5b3ea235ae0ec846b84d2be73ae > Cr-Commit-Position: refs/heads/master@{#350849} TBR=binji@chromium.org,bradnelson@chromium.org,sbc@chromium.org,avallee@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=532095 Committed: https://crrev.com/cdc76669194bd2f0402155f4a2da9905bbe3f81a Cr-Commit-Position: refs/heads/master@{#350865}

Patch Set 1 #

Messages

Total messages: 8 (0 generated)
cmumford
Created Revert of [NaCl SDK] nacl_io: Add support for basic socketpairs.
5 years, 2 months ago (2015-09-25 18:12:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373563003/1
5 years, 2 months ago (2015-09-25 18:14:27 UTC) #2
Sam Clegg
On 2015/09/25 18:12:42, cmumford wrote: > Created Revert of [NaCl SDK] nacl_io: Add support for ...
5 years, 2 months ago (2015-09-25 18:14:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 18:16:07 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cdc76669194bd2f0402155f4a2da9905bbe3f81a Cr-Commit-Position: refs/heads/master@{#350865}
5 years, 2 months ago (2015-09-25 18:17:01 UTC) #5
avallee
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/6088/steps/steps/logs/stdio shows the error. I think this failed since I added a new file but ...
5 years, 2 months ago (2015-09-30 18:27:11 UTC) #6
Sam Clegg
On 2015/09/30 18:27:11, avallee wrote: > http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/6088/steps/steps/logs/stdio > shows the error. > > I think ...
5 years, 2 months ago (2015-09-30 18:31:34 UTC) #7
avallee
5 years, 2 months ago (2015-09-30 18:33:00 UTC) #8
Message was sent while issue was closed.
Got buried under a Mac ASAN thing that was unrelated but that I was on the
blamelist. I did get the email, but didn't read that one correctly.

On Wed, Sep 30, 2015 at 2:31 PM, <sbc@chromium.org> wrote:

> On 2015/09/30 18:27:11, avallee wrote:
>
>
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/buil...
>
>> shows the error.
>>
>
> I think this failed since I added a new file but did not update BUILD.gn.
>>
>
> Looks like it yes.  I don't understand any we didn't see a trybot failure
> though.
>
>
>
> On Fri, Sep 25, 2015 at 2:17 PM, mailto:commit-bot@chromium.org via
>> http://codereview.chromium.org
>>
> <mailto:reply@chromiumcodereview-hr.appspotmail.com> wrote:
>
> > Patchset 1 (id:??) landed as
>> > https://crrev.com/cdc76669194bd2f0402155f4a2da9905bbe3f81a
>> > Cr-Commit-Position: refs/heads/master@{#350865}
>> >
>> > https://codereview.chromium.org/1373563003/
>> >
>>
>
> To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
>
>
> https://codereview.chromium.org/1373563003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698