Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 137353003: Pepper: Reduce includes in generated thunks. (Closed)

Created:
6 years, 11 months ago by teravest
Modified:
6 years, 11 months ago
CC:
chromium-reviews, scheib+watch_chromium.org
Visibility:
Public.

Description

Pepper: Reduce includes in generated thunks. There are some unnecessary includes in generated thunks. We should remove these for clarity, and (hopefully) to reduce build time. A small test showed that ppb_view_thunk.cc built 18% faster after the change, but that's well within the noise on my local system. BUG=334727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -219 lines) Patch
M ppapi/generators/idl_thunk.py View 2 chunks +5 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_console_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_content_decryptor_private_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_device_ref_dev_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_file_chooser_dev_thunk.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_file_chooser_trusted_thunk.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_file_io_thunk.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_file_system_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_find_dev_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_flash_drm_thunk.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_fullscreen_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_gamepad_thunk.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_graphics_2d_dev_thunk.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_graphics_2d_thunk.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_host_resolver_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_image_data_thunk.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_instance_private_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_instance_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_isolated_file_system_private_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_media_stream_video_track_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_messaging_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_mouse_cursor_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_mouse_lock_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_network_list_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_network_monitor_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_network_proxy_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_output_protection_private_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_platform_verification_private_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_printing_dev_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_truetype_font_dev_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_udp_socket_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_url_loader_thunk.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_url_loader_trusted_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_url_request_info_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_url_response_info_thunk.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_video_frame_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_view_dev_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_view_thunk.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_websocket_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_widget_dev_thunk.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_zoom_dev_thunk.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
teravest
6 years, 11 months ago (2014-01-15 17:59:46 UTC) #1
Nico
Awesome! (re noise: I usually do min-of-3-builds build times before/after, this tends to be relatively ...
6 years, 11 months ago (2014-01-15 18:04:20 UTC) #2
dmichael (off chromium)
Nice! lgtm, assuming trybots like it
6 years, 11 months ago (2014-01-15 18:10:44 UTC) #3
teravest
Doing min-of-3-builds on just obj/ppapi/thunk/ppapi_shared.ppb_view_thunk.o: Before change: 1.03s user After change: 0.97s user Not very ...
6 years, 11 months ago (2014-01-15 18:23:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/137353003/1
6 years, 11 months ago (2014-01-15 18:48:59 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 04:34:39 UTC) #6
Message was sent while issue was closed.
Change committed as 245111

Powered by Google App Engine
This is Rietveld 408576698