Issue 137353002: Remove GetMonitorInfoWrapper, which is no longer needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137353002: Remove GetMonitorInfoWrapper, which is no longer needed. (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 10 months ago

Reviewers:
Shrikant Kelkar

CC:
chromium-reviews, extensions-reviews_chromium.org, James Su, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, ben+views_chromium.org, erikwright+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove GetMonitorInfoWrapper, which is no longer needed. We always use ASH on Windows, so the code in the wrapper does not have any effect. This removes the wrapper and updates the callers to use the unwrapped Windows API verison. R=shrikant@chromium.org BUG=247430 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247204

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3236 lines, -45 lines)			Patch
M	base/win/win_util.h	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	base/win/win_util.cc	View	1 2	1 chunk	+0 lines, -27 lines	0 comments	Download
M	chrome/browser/extensions/api/system_display/display_info_provider_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/fullscreen_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	content/browser/renderer_host/render_widget_host_view_win.cc	View	1 2	1 chunk	+3222 lines, -0 lines	0 comments	Download
M	ui/gfx/screen_win.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/gfx/win/hwnd_util.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/widget/monitor_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/win/fullscreen_handler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Shrikant Kelkar

On 2014/01/13 20:42:35, brettw wrote: I am fine with this change, but just wanted to ...

6 years, 11 months ago (2014-01-21 20:11:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r247204.

Expand Messages | Collapse Messages