Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373523002: [heap] Move large object space selection into AllocateRaw. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move large object space selection into AllocateRaw. BUG= Committed: https://crrev.com/e4f7ebb000432cc2011ecaaa71a69e2e60f416f0 Cr-Commit-Position: refs/heads/master@{#30938}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -35 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 12 chunks +12 lines, -15 lines 0 comments Download
M src/heap/heap-inl.h View 1 3 chunks +23 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
5 years, 2 months ago (2015-09-25 12:55:51 UTC) #2
Michael Lippautz
LGTM, the branching in AllocateRaw is tricky...
5 years, 2 months ago (2015-09-25 13:34:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373523002/20001
5 years, 2 months ago (2015-09-25 13:50:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 13:54:08 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e4f7ebb000432cc2011ecaaa71a69e2e60f416f0 Cr-Commit-Position: refs/heads/master@{#30938}
5 years, 2 months ago (2015-09-25 13:54:20 UTC) #7
Michael Achenbach
5 years, 2 months ago (2015-09-25 16:10:51 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1368833004/ by machenbach@chromium.org.

The reason for reverting is: Breaks mac asan:
http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/2895

According to auto bisect.

Powered by Google App Engine
This is Rietveld 408576698