Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2698)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 1373453002: Allow the site engagement service thresholds to be varied via field trial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@time-on-site-uma
Patch Set: Reviewer nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/engagement/site_engagement_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/site_engagement_service_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_service_unittest.cc b/chrome/browser/engagement/site_engagement_service_unittest.cc
index 8b171f82f834677555bb6c9d10f71a51bd4a6d21..00186961376b68281118c87e96e622cd1c024902 100644
--- a/chrome/browser/engagement/site_engagement_service_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_service_unittest.cc
@@ -93,19 +93,19 @@ class SiteEngagementScoreTest : public testing::Test {
};
// Accumulate score many times on the same day. Ensure each time the score goes
-// up by kNavigationPoints, but not more than kMaxPointsPerDay.
+// up by g_navigation_points, but not more than g_max_points_per_day.
TEST_F(SiteEngagementScoreTest, AccumulateOnSameDay) {
base::Time reference_time = GetReferenceTime();
test_clock_.SetNow(reference_time);
for (int i = 0; i < kMoreAccumulationsThanNeededToMaxDailyEngagement; ++i) {
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
- EXPECT_EQ(std::min(SiteEngagementScore::kMaxPointsPerDay,
- (i + 1) * SiteEngagementScore::kNavigationPoints),
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
+ EXPECT_EQ(std::min(SiteEngagementScore::g_max_points_per_day,
+ (i + 1) * SiteEngagementScore::g_navigation_points),
score_.Score());
}
- EXPECT_EQ(SiteEngagementScore::kMaxPointsPerDay, score_.Score());
+ EXPECT_EQ(SiteEngagementScore::g_max_points_per_day, score_.Score());
}
// Accumulate on the first day to max that day's engagement, then accumulate on
@@ -116,21 +116,21 @@ TEST_F(SiteEngagementScoreTest, AccumulateOnTwoDays) {
test_clock_.SetNow(reference_time);
for (int i = 0; i < kMoreAccumulationsThanNeededToMaxDailyEngagement; ++i)
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
- EXPECT_EQ(SiteEngagementScore::kMaxPointsPerDay, score_.Score());
+ EXPECT_EQ(SiteEngagementScore::g_max_points_per_day, score_.Score());
test_clock_.SetNow(later_date);
for (int i = 0; i < kMoreAccumulationsThanNeededToMaxDailyEngagement; ++i) {
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
double day_score =
- std::min(SiteEngagementScore::kMaxPointsPerDay,
- (i + 1) * SiteEngagementScore::kNavigationPoints);
- EXPECT_EQ(day_score + SiteEngagementScore::kMaxPointsPerDay,
+ std::min(SiteEngagementScore::g_max_points_per_day,
+ (i + 1) * SiteEngagementScore::g_navigation_points);
+ EXPECT_EQ(day_score + SiteEngagementScore::g_max_points_per_day,
score_.Score());
}
- EXPECT_EQ(2 * SiteEngagementScore::kMaxPointsPerDay, score_.Score());
+ EXPECT_EQ(2 * SiteEngagementScore::g_max_points_per_day, score_.Score());
}
// Accumulate score on many consecutive days and ensure the score doesn't exceed
@@ -142,10 +142,10 @@ TEST_F(SiteEngagementScoreTest, AccumulateALotOnManyDays) {
current_day += base::TimeDelta::FromDays(1);
test_clock_.SetNow(current_day);
for (int j = 0; j < kMoreAccumulationsThanNeededToMaxDailyEngagement; ++j)
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
EXPECT_EQ(std::min(SiteEngagementScore::kMaxPoints,
- (i + 1) * SiteEngagementScore::kMaxPointsPerDay),
+ (i + 1) * SiteEngagementScore::g_max_points_per_day),
score_.Score());
}
@@ -162,12 +162,12 @@ TEST_F(SiteEngagementScoreTest, AccumulateALittleOnManyDays) {
test_clock_.SetNow(current_day);
for (int j = 0; j < kLessAccumulationsThanNeededToMaxDailyEngagement; ++j)
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
EXPECT_EQ(
std::min(SiteEngagementScore::kMaxPoints,
(i + 1) * kLessAccumulationsThanNeededToMaxDailyEngagement *
- SiteEngagementScore::kNavigationPoints),
+ SiteEngagementScore::g_navigation_points),
score_.Score());
}
@@ -184,42 +184,43 @@ TEST_F(SiteEngagementScoreTest, ScoresDecayOverTime) {
test_clock_.SetNow(current_day);
for (int j = 0; j < kMoreAccumulationsThanNeededToMaxDailyEngagement; ++j)
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
}
EXPECT_EQ(SiteEngagementScore::kMaxPoints, score_.Score());
// The score should not have decayed before the first decay period has
// elapsed.
- test_clock_.SetNow(
- current_day +
- base::TimeDelta::FromDays(SiteEngagementScore::kDecayPeriodInDays - 1));
+ test_clock_.SetNow(current_day +
+ base::TimeDelta::FromDays(
+ SiteEngagementScore::g_decay_period_in_days - 1));
EXPECT_EQ(SiteEngagementScore::kMaxPoints, score_.Score());
// The score should have decayed by one chunk after one decay period has
// elapsed.
test_clock_.SetNow(
current_day +
- base::TimeDelta::FromDays(SiteEngagementScore::kDecayPeriodInDays));
- EXPECT_EQ(SiteEngagementScore::kMaxPoints - SiteEngagementScore::kDecayPoints,
- score_.Score());
+ base::TimeDelta::FromDays(SiteEngagementScore::g_decay_period_in_days));
+ EXPECT_EQ(
+ SiteEngagementScore::kMaxPoints - SiteEngagementScore::g_decay_points,
+ score_.Score());
// The score should have decayed by the right number of chunks after a few
// decay periods have elapsed.
test_clock_.SetNow(
current_day +
base::TimeDelta::FromDays(kLessPeriodsThanNeededToDecayMaxScore *
- SiteEngagementScore::kDecayPeriodInDays));
+ SiteEngagementScore::g_decay_period_in_days));
EXPECT_EQ(SiteEngagementScore::kMaxPoints -
kLessPeriodsThanNeededToDecayMaxScore *
- SiteEngagementScore::kDecayPoints,
+ SiteEngagementScore::g_decay_points,
score_.Score());
// The score should not decay below zero.
test_clock_.SetNow(
current_day +
base::TimeDelta::FromDays(kMorePeriodsThanNeededToDecayMaxScore *
- SiteEngagementScore::kDecayPeriodInDays));
+ SiteEngagementScore::g_decay_period_in_days));
EXPECT_EQ(0, score_.Score());
}
@@ -233,27 +234,27 @@ TEST_F(SiteEngagementScoreTest, DecaysAppliedBeforeAdd) {
test_clock_.SetNow(current_day);
for (int j = 0; j < kMoreAccumulationsThanNeededToMaxDailyEngagement; ++j)
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
}
double initial_score = kLessDaysThanNeededToMaxTotalEngagement *
- SiteEngagementScore::kMaxPointsPerDay;
+ SiteEngagementScore::g_max_points_per_day;
EXPECT_EQ(initial_score, score_.Score());
// Go forward a few decay periods.
test_clock_.SetNow(
current_day +
base::TimeDelta::FromDays(kLessPeriodsThanNeededToDecayMaxScore *
- SiteEngagementScore::kDecayPeriodInDays));
+ SiteEngagementScore::g_decay_period_in_days));
- double decayed_score =
- initial_score -
- kLessPeriodsThanNeededToDecayMaxScore * SiteEngagementScore::kDecayPoints;
+ double decayed_score = initial_score -
+ kLessPeriodsThanNeededToDecayMaxScore *
+ SiteEngagementScore::g_decay_points;
EXPECT_EQ(decayed_score, score_.Score());
// Now add some points.
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
- EXPECT_EQ(decayed_score + SiteEngagementScore::kNavigationPoints,
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
+ EXPECT_EQ(decayed_score + SiteEngagementScore::g_navigation_points,
score_.Score());
}
@@ -263,25 +264,25 @@ TEST_F(SiteEngagementScoreTest, GoBackInTime) {
test_clock_.SetNow(current_day);
for (int i = 0; i < kMoreAccumulationsThanNeededToMaxDailyEngagement; ++i)
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
- EXPECT_EQ(SiteEngagementScore::kMaxPointsPerDay, score_.Score());
+ EXPECT_EQ(SiteEngagementScore::g_max_points_per_day, score_.Score());
// Adding to the score on an earlier date should be treated like another day,
// and should not cause any decay.
test_clock_.SetNow(current_day - base::TimeDelta::FromDays(
kMorePeriodsThanNeededToDecayMaxScore *
- SiteEngagementScore::kDecayPoints));
+ SiteEngagementScore::g_decay_points));
for (int i = 0; i < kMoreAccumulationsThanNeededToMaxDailyEngagement; ++i) {
- score_.AddPoints(SiteEngagementScore::kNavigationPoints);
+ score_.AddPoints(SiteEngagementScore::g_navigation_points);
double day_score =
- std::min(SiteEngagementScore::kMaxPointsPerDay,
- (i + 1) * SiteEngagementScore::kNavigationPoints);
- EXPECT_EQ(day_score + SiteEngagementScore::kMaxPointsPerDay,
+ std::min(SiteEngagementScore::g_max_points_per_day,
+ (i + 1) * SiteEngagementScore::g_navigation_points);
+ EXPECT_EQ(day_score + SiteEngagementScore::g_max_points_per_day,
score_.Score());
}
- EXPECT_EQ(2 * SiteEngagementScore::kMaxPointsPerDay, score_.Score());
+ EXPECT_EQ(2 * SiteEngagementScore::g_max_points_per_day, score_.Score());
}
// Test that scores are read / written correctly from / to empty score
@@ -707,7 +708,7 @@ TEST_F(SiteEngagementServiceTest, CleanupEngagementScores) {
// will not have decayed at all.
clock->SetNow(
GetReferenceTime() +
- base::TimeDelta::FromDays(SiteEngagementScore::kDecayPeriodInDays));
+ base::TimeDelta::FromDays(SiteEngagementScore::g_decay_period_in_days));
std::map<GURL, double> score_map = service->GetScoreMap();
EXPECT_EQ(2u, score_map.size());
@@ -725,9 +726,9 @@ TEST_F(SiteEngagementServiceTest, CleanupEngagementScores) {
{
// Decay the other origin to zero by advancing time and expect the
// engagement score to be cleaned up.
- clock->SetNow(
- GetReferenceTime() +
- base::TimeDelta::FromDays(3 * SiteEngagementScore::kDecayPeriodInDays));
+ clock->SetNow(GetReferenceTime() +
+ base::TimeDelta::FromDays(
+ 3 * SiteEngagementScore::g_decay_period_in_days));
std::map<GURL, double> score_map = service->GetScoreMap();
EXPECT_EQ(1u, score_map.size());
« no previous file with comments | « chrome/browser/engagement/site_engagement_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698