third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp - Issue 1373433002: Split out CSSPrimitiveValue's PropertyID into CSSCustomIdentValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

Issue 1373433002: Split out CSSPrimitiveValue's PropertyID into CSSCustomIdentValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_string

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSCustomIdentValue.h ('K') | « third_party/WebKit/Source/core/css/CSSCustomIdentValue.h ('k') | third_party/WebKit/Source/core/css/CSSPrimitiveValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp b/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

index e9e3cf3bdc53a5d22a32d5addb6dcf33e797b681..a1a3661c28568e2eae72eec999eae4e668f4e259 100644

--- a/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp

@@ -12,10 +12,22 @@ namespace blink {

CSSCustomIdentValue::CSSCustomIdentValue(const String& str)

: CSSValue(CustomIdentClass)

- , m_string(str) { }

+ , m_string(str)

+ , m_propertyId(CSSPropertyInvalid) { }

+CSSCustomIdentValue::CSSCustomIdentValue(CSSPropertyID id)

+ : CSSValue(CustomIdentClass)

+ , m_string()

+ , m_propertyId(id)

+ ASSERT(isKnownPropertyID());

String CSSCustomIdentValue::customCSSText() const

{

+ if (isKnownPropertyID())

+ return getPropertyNameAtomicString(m_propertyId);

return quoteCSSStringIfNeeded(m_string);

}