Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

Issue 1373433002: Split out CSSPrimitiveValue's PropertyID into CSSCustomIdentValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_string
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp b/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp
index f0ac5560074e13fb2751e0db3105046f763d5429..a67119689b19c12099fbb71feccf23e53f7d338b 100644
--- a/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp
@@ -349,7 +349,7 @@ AtomicString CSSToStyleMap::mapAnimationName(CSSValue* value)
return CSSAnimationData::initialName();
if (value->isPrimitiveValue() && toCSSPrimitiveValue(value)->getValueID() == CSSValueNone)
return CSSAnimationData::initialName();
- return AtomicString(toCSSCustomIdentValue(value)->value());
+ return AtomicString(toCSSCustomIdentValue(value)->string());
}
EAnimPlayState CSSToStyleMap::mapAnimationPlayState(CSSValue* value)
@@ -366,12 +366,14 @@ CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(CSSVal
{
if (value->isInitialValue())
return CSSTransitionData::initialProperty();
- if (value->isCustomIdentValue())
- return CSSTransitionData::TransitionProperty(toCSSCustomIdentValue(value)->value());
- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
- if (primitiveValue->getValueID() == CSSValueNone)
- return CSSTransitionData::TransitionProperty(CSSTransitionData::TransitionNone);
- return CSSTransitionData::TransitionProperty(primitiveValue->getPropertyID());
+ if (value->isCustomIdentValue()) {
+ const CSSCustomIdentValue& customIdentValue = toCSSCustomIdentValue(*value);
+ if (customIdentValue.isValidPropertyID())
+ return CSSTransitionData::TransitionProperty(customIdentValue.id());
+ return CSSTransitionData::TransitionProperty(customIdentValue.string());
+ }
+ ASSERT(toCSSPrimitiveValue(value)->getValueID() == CSSValueNone);
+ return CSSTransitionData::TransitionProperty(CSSTransitionData::TransitionNone);
}
PassRefPtr<TimingFunction> CSSToStyleMap::mapAnimationTimingFunction(CSSValue* value, bool allowStepMiddle)

Powered by Google App Engine
This is Rietveld 408576698