third_party/WebKit/Source/core/css/CSSValuePool.cpp - Issue 1373433002: Split out CSSPrimitiveValue's PropertyID into CSSCustomIdentValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValuePool.cpp

Issue 1373433002: Split out CSSPrimitiveValue's PropertyID into CSSCustomIdentValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_string

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSStringValues.cpp ('K') | « third_party/WebKit/Source/core/css/CSSValuePool.h ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSValuePool.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSValuePool.cpp b/third_party/WebKit/Source/core/css/CSSValuePool.cpp

index cefc7db287715ddeaef242f669d68bd682a21c3e..095b1a3f612f463b4b3750ec09ff62da941621fc 100644

--- a/third_party/WebKit/Source/core/css/CSSValuePool.cpp

+++ b/third_party/WebKit/Source/core/css/CSSValuePool.cpp

@@ -26,7 +26,7 @@

#include "config.h"

#include "core/css/CSSValuePool.h"

-#include "core/css/CSSStringValueBase.h"

+#include "core/css/CSSStringValues.h"

#include "core/css/CSSValueList.h"

#include "core/css/parser/CSSParser.h"

#include "core/style/ComputedStyle.h"

@@ -64,9 +64,9 @@ PassRefPtrWillBeRawPtr<CSSPrimitiveValue> CSSValuePool::createIdentifierValue(CS

return m_identifierValueCache[ident];

}

-PassRefPtrWillBeRawPtr<CSSPrimitiveValue> CSSValuePool::createIdentifierValue(CSSPropertyID ident)

+PassRefPtrWillBeRawPtr<CSSCustomIdentValue> CSSValuePool::createIdentifierValue(CSSPropertyID ident)

{

- return CSSPrimitiveValue::createIdentifier(ident);

+ return CSSCustomIdentValue::create(ident);

}

PassRefPtrWillBeRawPtr<CSSPrimitiveValue> CSSValuePool::createColorValue(unsigned rgbValue)