Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

Issue 1373433002: Split out CSSPrimitiveValue's PropertyID into CSSCustomIdentValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_string
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
index 4e9a8bcd98a051505bc34c04846222b311e22f33..40f2c48bbd7a9bd0382069a3a73e7b052c026f5e 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
@@ -190,11 +190,6 @@ CSSPrimitiveValue::UnitType CSSPrimitiveValue::typeWithCalcResolved() const
return UnitType::Unknown;
}
-static const AtomicString& propertyName(CSSPropertyID propertyID)
-{
- return getPropertyNameAtomicString(propertyID);
-}
-
static const AtomicString& valueName(CSSValueID valueID)
{
ASSERT_ARG(valueID, valueID >= 0);
@@ -217,13 +212,6 @@ CSSPrimitiveValue::CSSPrimitiveValue(CSSValueID valueID)
m_value.valueID = valueID;
}
-CSSPrimitiveValue::CSSPrimitiveValue(CSSPropertyID propertyID)
- : CSSValue(PrimitiveClass)
-{
- init(UnitType::PropertyID);
- m_value.propertyID = propertyID;
-}
-
CSSPrimitiveValue::CSSPrimitiveValue(double num, UnitType type)
: CSSValue(PrimitiveClass)
{
@@ -373,7 +361,6 @@ void CSSPrimitiveValue::cleanup()
case UnitType::Fraction:
case UnitType::RGBColor:
case UnitType::Unknown:
- case UnitType::PropertyID:
case UnitType::ValueID:
break;
}
@@ -799,7 +786,6 @@ const char* CSSPrimitiveValue::unitTypeToString(UnitType type)
return "vmax";
case UnitType::Unknown:
case UnitType::ValueID:
- case UnitType::PropertyID:
case UnitType::RGBColor:
case UnitType::Calc:
case UnitType::CalcPercentageWithNumber:
@@ -859,9 +845,6 @@ String CSSPrimitiveValue::customCSSText() const
case UnitType::ValueID:
text = valueName(m_value.valueID);
break;
- case UnitType::PropertyID:
- text = propertyName(m_value.propertyID);
- break;
case UnitType::RGBColor: {
text = Color(m_value.rgbcolor).serializedAsCSSComponentValue();
break;
@@ -917,8 +900,6 @@ bool CSSPrimitiveValue::equals(const CSSPrimitiveValue& other) const
case UnitType::ViewportMax:
case UnitType::Fraction:
return m_value.num == other.m_value.num;
- case UnitType::PropertyID:
- return m_value.propertyID == other.m_value.propertyID;
case UnitType::ValueID:
return m_value.valueID == other.m_value.valueID;
case UnitType::RGBColor:

Powered by Google App Engine
This is Rietveld 408576698