third_party/WebKit/Source/core/css/CSSCounterValue.h - Issue 1373433002: Split out CSSPrimitiveValue's PropertyID into CSSCustomIdentValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCounterValue.h

Issue 1373433002: Split out CSSPrimitiveValue's PropertyID into CSSCustomIdentValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_string

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSCalculationValue.cpp ('k') | third_party/WebKit/Source/core/css/CSSPrimitiveValue.h » ('j') | third_party/WebKit/Source/core/css/CSSStringValues.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSCounterValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSCounterValue.h b/third_party/WebKit/Source/core/css/CSSCounterValue.h

index b60989b9326f78aff4816dabfd75c84b56e0b7a6..d79a4dfe45a14fbd2b7f215214e9beae3f5d2bed 100644

--- a/third_party/WebKit/Source/core/css/CSSCounterValue.h

+++ b/third_party/WebKit/Source/core/css/CSSCounterValue.h

@@ -22,7 +22,7 @@

#define CSSCounterValue_h

#include "core/css/CSSPrimitiveValue.h"

-#include "core/css/CSSStringValueBase.h"

+#include "core/css/CSSStringValues.h"

#include "core/css/CSSValue.h"

#include "wtf/text/WTFString.h"

@@ -35,9 +35,9 @@ public:

return adoptRefWillBeNoop(new CSSCounterValue(identifier, listStyle, separator));

}

- String identifier() const { return m_identifier->value(); }

+ String identifier() const { return m_identifier->string(); }

CSSValueID listStyle() const { return m_listStyle->getValueID(); }

- String separator() const { return m_separator->value(); }

+ String separator() const { return m_separator->string(); }

bool equals(const CSSCounterValue& other) const

{