Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

Issue 1373433002: Split out CSSPrimitiveValue's PropertyID into CSSCustomIdentValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_string
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 if (toCSSPrimitiveValue(value)->getValueID() == CSSValuePaused) 361 if (toCSSPrimitiveValue(value)->getValueID() == CSSValuePaused)
362 return AnimPlayStatePaused; 362 return AnimPlayStatePaused;
363 ASSERT(toCSSPrimitiveValue(value)->getValueID() == CSSValueRunning); 363 ASSERT(toCSSPrimitiveValue(value)->getValueID() == CSSValueRunning);
364 return AnimPlayStatePlaying; 364 return AnimPlayStatePlaying;
365 } 365 }
366 366
367 CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(CSSVal ue* value) 367 CSSTransitionData::TransitionProperty CSSToStyleMap::mapAnimationProperty(CSSVal ue* value)
368 { 368 {
369 if (value->isInitialValue()) 369 if (value->isInitialValue())
370 return CSSTransitionData::initialProperty(); 370 return CSSTransitionData::initialProperty();
371 if (value->isCustomIdentValue()) 371 if (value->isCustomIdentValue()) {
372 return CSSTransitionData::TransitionProperty(toCSSCustomIdentValue(value )->value()); 372 const CSSCustomIdentValue& customIdentValue = toCSSCustomIdentValue(*val ue);
373 if (customIdentValue.isKnownPropertyID())
374 return CSSTransitionData::TransitionProperty(customIdentValue.valueA sPropertyID());
375 return CSSTransitionData::TransitionProperty(customIdentValue.value());
376 }
373 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value); 377 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
374 if (primitiveValue->getValueID() == CSSValueNone) 378 ASSERT(primitiveValue->getValueID() == CSSValueNone);
375 return CSSTransitionData::TransitionProperty(CSSTransitionData::Transiti onNone); 379 return CSSTransitionData::TransitionProperty(CSSTransitionData::TransitionNo ne);
376 return CSSTransitionData::TransitionProperty(primitiveValue->getPropertyID() );
377 } 380 }
378 381
379 PassRefPtr<TimingFunction> CSSToStyleMap::mapAnimationTimingFunction(CSSValue* v alue, bool allowStepMiddle) 382 PassRefPtr<TimingFunction> CSSToStyleMap::mapAnimationTimingFunction(CSSValue* v alue, bool allowStepMiddle)
380 { 383 {
381 // FIXME: We should probably only call into this function with a valid 384 // FIXME: We should probably only call into this function with a valid
382 // single timing function value which isn't initial or inherit. We can 385 // single timing function value which isn't initial or inherit. We can
383 // currently get into here with initial since the parser expands unset 386 // currently get into here with initial since the parser expands unset
384 // properties in shorthands to initial. 387 // properties in shorthands to initial.
385 388
386 if (value->isPrimitiveValue()) { 389 if (value->isPrimitiveValue()) {
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 verticalRule = SpaceImageRule; 584 verticalRule = SpaceImageRule;
582 break; 585 break;
583 default: // CSSValueRepeat 586 default: // CSSValueRepeat
584 verticalRule = RepeatImageRule; 587 verticalRule = RepeatImageRule;
585 break; 588 break;
586 } 589 }
587 image.setVerticalRule(verticalRule); 590 image.setVerticalRule(verticalRule);
588 } 591 }
589 592
590 }; 593 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698