Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137343008: Make chrome.fileSystem.chooseEntry work on Google Drive directories. (Closed)

Created:
6 years, 11 months ago by kinaba
Modified:
6 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Make chrome.fileSystem.chooseEntry work on Google Drive directories. BUG=323097 TEST=added auto tests, and manually tested by samples apps for the API Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245453

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -10 lines) Patch
M chrome/browser/chromeos/drive/file_system_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 3 chunks +20 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc View 3 chunks +59 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinaba
PTAL. The CL depends on the previous CL adding the test class: https://codereview.chromium.org/137463006/. https://codereview.chromium.org/137343008/diff/90001/chrome/browser/drive/fake_drive_service.cc File ...
6 years, 11 months ago (2014-01-16 03:16:31 UTC) #1
hashimoto
chrome/browser/chromeos/drive and chrome/browser/drive lgtm
6 years, 11 months ago (2014-01-16 04:43:56 UTC) #2
benwells
+sammc to review who knows file system as well as i do
6 years, 11 months ago (2014-01-16 05:42:57 UTC) #3
Sam McNally
lgtm
6 years, 11 months ago (2014-01-16 23:43:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/137343008/90001
6 years, 11 months ago (2014-01-17 01:35:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=215267
6 years, 11 months ago (2014-01-17 02:35:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/137343008/90001
6 years, 11 months ago (2014-01-17 02:49:21 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=113195
6 years, 11 months ago (2014-01-17 04:00:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/137343008/490001
6 years, 11 months ago (2014-01-17 04:06:09 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 06:58:06 UTC) #10
Message was sent while issue was closed. 
Change committed as 245453

Powered by Google App Engine
This is Rietveld 408576698