Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137343005: Send multiple queries when DiscoverNewServices is called on a service watcher (Closed)

Created:
6 years, 11 months ago by Noam Samuel
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Send multiple queries when DiscoverNewServices is called on a service watcher Send multiple queries to the network in short intervals to account for potential packet loss on noisy networks. BUG=332629 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 4 chunks +2 lines, -24 lines 0 comments Download
M chrome/utility/local_discovery/service_discovery_client_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/utility/local_discovery/service_discovery_client_impl.cc View 3 chunks +23 lines, -2 lines 0 comments Download
M chrome/utility/local_discovery/service_discovery_client_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Noam Samuel
6 years, 11 months ago (2014-01-14 00:23:06 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 11 months ago (2014-01-14 00:53:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/137343005/1
6 years, 11 months ago (2014-01-14 02:31:34 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=245898
6 years, 11 months ago (2014-01-14 08:03:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/137343005/1
6 years, 11 months ago (2014-01-14 18:55:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/137343005/1
6 years, 11 months ago (2014-01-14 23:27:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/137343005/1
6 years, 11 months ago (2014-01-15 03:11:45 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 04:34:05 UTC) #8
Message was sent while issue was closed. 
Change committed as 245110

Powered by Google App Engine
This is Rietveld 408576698