kiosk: Do update check during launch.

kiosk: Do update check during launch.

- Check app update during launching;
- Update cached app data when app is installed/updated;

BUG=330713
R=tengs@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244632

[xiyuan, 2014-01-13 21:43:51]

Adding a new KioskTest too but probably will be in a separate CL.

[Tim Song, 2014-01-13 23:41:08]

lgtm

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
File chrome/browser/chromeos/app_mode/kiosk_app_data.cc (right):

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/kiosk_app_data.cc:385: void
KioskAppData::SetCachedIcon(const SkBitmap& icon) {
nit: This function is also calling SetCache() at the end for the name, so it
might be a good idea to overload SetCache to be clear

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
File chrome/browser/chromeos/app_mode/kiosk_app_data.h (right):

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/kiosk_app_data.h:65: void
UpdateFromProfile(Profile* profile, const extensions::Extension* app);
nit: I would change the name to LoadFromInstalledApp() for parallelism with the
other Load functions and "Update" is a bit misleading as this function doesn't
need the status to be STATUS_LOADED.

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
File chrome/browser/chromeos/app_mode/startup_app_launcher.cc (right):

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/startup_app_launcher.cc:406: void
StartupAppLauncher::UpdateAppData() {
Can't hurt to call ClearAppData here as well.

[xiyuan, 2014-01-14 00:15:07]

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
File chrome/browser/chromeos/app_mode/kiosk_app_data.cc (right):

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/kiosk_app_data.cc:385: void
KioskAppData::SetCachedIcon(const SkBitmap& icon) {
On 2014/01/13 23:41:08, Tim Song wrote:
> nit: This function is also calling SetCache() at the end for the name, so it
> might be a good idea to overload SetCache to be clear

Done.

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
File chrome/browser/chromeos/app_mode/kiosk_app_data.h (right):

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/kiosk_app_data.h:65: void
UpdateFromProfile(Profile* profile, const extensions::Extension* app);
On 2014/01/13 23:41:08, Tim Song wrote:
> nit: I would change the name to LoadFromInstalledApp() for parallelism with
the
> other Load functions and "Update" is a bit misleading as this function doesn't
> need the status to be STATUS_LOADED.

Done.

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
File chrome/browser/chromeos/app_mode/startup_app_launcher.cc (right):

https://codereview.chromium.org/137343003/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/startup_app_launcher.cc:406: void
StartupAppLauncher::UpdateAppData() {
On 2014/01/13 23:41:08, Tim Song wrote:
> Can't hurt to call ClearAppData here as well.

Done.

[commit-bot: I haz the power, 2014-01-14 01:00:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/137343003/260001

[xiyuan, 2014-01-14 02:05:11]

Committed patchset #2 manually as r244632 (presubmit successful).