Mac Overlays: Add AllOrNothing strategy

cc/output/overlay_candidate.h

Index: cc/output/overlay_candidate.h
diff --git a/cc/output/overlay_candidate.h b/cc/output/overlay_candidate.h
index 28ecfabe184b7eb8cb757d1aa0885d59ed818f69..95430de6389ebed1a6418da9d33e52f0e1f01180 100644
--- a/cc/output/overlay_candidate.h
+++ b/cc/output/overlay_candidate.h
@@ -21,18 +21,17 @@ class Rect;
 
 namespace cc {
 
+class DrawQuad;
+class IOSurfaceDrawQuad;
+class StreamVideoDrawQuad;
+class TextureDrawQuad;
+
 class CC_EXPORT OverlayCandidate {
  public:
-  static gfx::OverlayTransform GetOverlayTransform(
-      const gfx::Transform& quad_transform,
-      bool y_flipped);
-  // Apply transform |delta| to |in| and return the resulting transform,
-  // or OVERLAY_TRANSFORM_INVALID.
-  static gfx::OverlayTransform ModifyTransform(gfx::OverlayTransform in,
-                                               gfx::OverlayTransform delta);
-  static gfx::RectF GetOverlayRect(const gfx::Transform& quad_transform,
-                                   const gfx::Rect& rect);
-
+  // Returns true and fills in |candidate| if |draw_quad| is of a known quad
+  // type and contains an overlayable resource.
+  static bool FromDrawQuad(const DrawQuad* draw_quad,
+                           OverlayCandidate* candidate);
   OverlayCandidate();
   ~OverlayCandidate();
 
@@ -65,6 +64,23 @@ class CC_EXPORT OverlayCandidate {
   // To be modified by the implementer if this candidate can go into
   // an overlay.
   bool overlay_handled;
+
+ private:
+  static bool FromTextureQuad(const TextureDrawQuad* quad,
+                              OverlayCandidate* candidate);
+  static bool FromStreamVideoQuad(const StreamVideoDrawQuad* quad,
+                                  OverlayCandidate* candidate);
+  static bool FromIOSurfaceQuad(const IOSurfaceDrawQuad* quad,
+                                OverlayCandidate* candidate);

[ccameron, 2015/09/29 23:29:56]

I'd suggest making GetOverlayTransform be a non-member function, just inside
namespace {} in the .cc.

[Andre, 2015/09/30 00:18:38]

Done.

+  static gfx::OverlayTransform GetOverlayTransform(
+      const gfx::Transform& quad_transform,
+      bool y_flipped);

[ccameron, 2015/09/29 23:29:55]

I'd prefer to name "ModifyTransform" to be "ComposeTransforms" with the argument
order reversed, so ComposeTransforms(a, b)(x) = a(b(x)) -- that would me more in
line with the mathematical meaning of the transform.

[Andre, 2015/09/30 00:18:38]

Done.

+  // Apply transform |delta| to |in| and return the resulting transform,
+  // or OVERLAY_TRANSFORM_INVALID.
+  static gfx::OverlayTransform ModifyTransform(gfx::OverlayTransform in,
+                                               gfx::OverlayTransform delta);
+  static gfx::RectF GetOverlayRect(const gfx::Transform& quad_transform,
+                                   const gfx::Rect& rect);
 };
 
 typedef std::vector<OverlayCandidate> OverlayCandidateList;