Mac Overlays: Add AllOrNothing strategy

cc/output/overlay_candidate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_OUTPUT_OVERLAY_CANDIDATE_H_
 #define CC_OUTPUT_OVERLAY_CANDIDATE_H_
 
 #include <vector>
 
 #include "cc/base/cc_export.h"
 #include "cc/resources/resource_format.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/rect_f.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/overlay_transform.h"
 #include "ui/gfx/transform.h"
 
 namespace gfx {
 class Rect;
 }
 
 namespace cc {
 
+class DrawQuad;
+class IOSurfaceDrawQuad;
+class StreamVideoDrawQuad;
+class TextureDrawQuad;
+
 class CC_EXPORT OverlayCandidate {
  public:
-  static gfx::OverlayTransform GetOverlayTransform(
-      const gfx::Transform& quad_transform,
-      bool y_flipped);
-  // Apply transform |delta| to |in| and return the resulting transform,
-  // or OVERLAY_TRANSFORM_INVALID.
-  static gfx::OverlayTransform ModifyTransform(gfx::OverlayTransform in,
-                                               gfx::OverlayTransform delta);
-  static gfx::RectF GetOverlayRect(const gfx::Transform& quad_transform,
-                                   const gfx::Rect& rect);
-
+  // Returns true and fills in |candidate| if |draw_quad| is of a known quad
+  // type and contains an overlayable resource.
+  static bool FromDrawQuad(const DrawQuad* draw_quad,
+                           OverlayCandidate* candidate);
   OverlayCandidate();
   ~OverlayCandidate();
 
   // Transformation to apply to layer during composition.
   gfx::OverlayTransform transform;
   // Format of the buffer to composite.
   ResourceFormat format;
   // Size of the resource, in pixels.
   gfx::Size resource_size_in_pixels;
   // Rect on the display to position the overlay to. Implementer must convert
@@ skipping 12 matching lines @@
   bool use_output_surface_for_resource;
   // Texture resource to present in an overlay.
   unsigned resource_id;
   // Stacking order of the overlay plane relative to the main surface,
   // which is 0. Signed to allow for "underlays".
   int plane_z_order;
 
   // To be modified by the implementer if this candidate can go into
   // an overlay.
   bool overlay_handled;
+
+ private:
+  static bool FromTextureQuad(const TextureDrawQuad* quad,
+                              OverlayCandidate* candidate);
+  static bool FromStreamVideoQuad(const StreamVideoDrawQuad* quad,
+                                  OverlayCandidate* candidate);
+  static bool FromIOSurfaceQuad(const IOSurfaceDrawQuad* quad,
+                                OverlayCandidate* candidate);

[ccameron, 2015/09/29 23:29:56]

I'd suggest making GetOverlayTransform be a non-member function, just inside
namespace {} in the .cc.

[Andre, 2015/09/30 00:18:38]

Done.

+  static gfx::OverlayTransform GetOverlayTransform(
+      const gfx::Transform& quad_transform,
+      bool y_flipped);

[ccameron, 2015/09/29 23:29:55]

I'd prefer to name "ModifyTransform" to be "ComposeTransforms" with the argument
order reversed, so ComposeTransforms(a, b)(x) = a(b(x)) -- that would me more in
line with the mathematical meaning of the transform.

[Andre, 2015/09/30 00:18:38]

Done.

+  // Apply transform |delta| to |in| and return the resulting transform,
+  // or OVERLAY_TRANSFORM_INVALID.
+  static gfx::OverlayTransform ModifyTransform(gfx::OverlayTransform in,
+                                               gfx::OverlayTransform delta);
+  static gfx::RectF GetOverlayRect(const gfx::Transform& quad_transform,
+                                   const gfx::Rect& rect);
 };
 
 typedef std::vector<OverlayCandidate> OverlayCandidateList;
 
 }  // namespace cc
 
 #endif  // CC_OUTPUT_OVERLAY_CANDIDATE_H_