Add a delay to Site Engagement tracking after navigation.

chrome/browser/engagement/site_engagement_helper.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_HELPER_H_
 #define CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_HELPER_H_
 
 #include "base/macros.h"
 #include "base/timer/timer.h"
 #include "content/public/browser/render_view_host.h"
@@ skipping 45 matching lines @@
     // Pause listening for user input, restarting listening after
     // g_seconds_between_user_input_check seconds.
     void PauseTracking(content::RenderViewHost* host);
 
     // Restart listening for user input.
     void ResumeTracking();
 
     // Stop listening for user input.
     void StopTracking(content::RenderViewHost* host);
 
+    // Returns whether a RenderViewHost is being tracked.
+    bool IsTracking();
+
     // Set the timer object for testing purposes.
-    void SetTimerForTesting(scoped_ptr<base::Timer> timer);
-
-    bool callbacks_added() { return callbacks_added_; }
+    void SetPauseTimerForTesting(scoped_ptr<base::Timer> timer);
 
    private:
     SiteEngagementHelper* helper_;
     scoped_ptr<base::Timer> pause_timer_;
     content::RenderWidgetHost::KeyPressEventCallback key_press_event_callback_;
     content::RenderWidgetHost::MouseEventCallback mouse_event_callback_;
     bool callbacks_added_;

[dominickn, 2015/10/06 00:04:41]

Nit: rename to is_tracking_ to match the function name.

[calamity, 2015/10/06 03:39:55]

Done.

   };
 
   explicit SiteEngagementHelper(content::WebContents* web_contents);
   friend class content::WebContentsUserData<SiteEngagementHelper>;
   friend class SiteEngagementServiceBrowserTest;
 
   // Ask the SiteEngagementService to record engagement via user input at the
   // current contents location.
   void RecordUserInput();
 
   bool ShouldRecordEngagement();

[dominickn, 2015/10/06 00:04:41]

Nit: remove this declaration since the function is gone.

[calamity, 2015/10/06 03:39:55]

Done.

 
   // content::WebContentsObserver overrides.
   void DidNavigateMainFrame(
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) override;
-
   void RenderViewHostChanged(content::RenderViewHost* old_host,
                              content::RenderViewHost* new_host) override;
-
   void WasShown() override;
   void WasHidden() override;
 
+  // Set the timer object for testing purposes.
+  void SetNavigationTimerForTesting(scoped_ptr<base::Timer> timer);
+  void OnNavigationTimerFired();
+
+  scoped_ptr<base::Timer> navigation_timer_;
   InputTracker input_tracker_;
   bool record_engagement_;
+  bool visible_;
 
   DISALLOW_COPY_AND_ASSIGN(SiteEngagementHelper);
 };
 
 #endif  // CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_HELPER_H_