Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373253003: Have /src files use header directly. (Closed)

Created:
5 years, 2 months ago by herb_g
Modified:
5 years, 2 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Have /src files use header directly. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b906daf112416c1698a79cf51aa70fe11aa19d0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M gyp/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkAAClip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapHeap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkClipStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDrawable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegionPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSharedMutex.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSharedMutex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkString.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTLS.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTaskGroup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTraceEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTypefaceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkEventTracer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkOSMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
herb_g
Change the SkAtomic include from the incorrect ../private/SkAtomic.h to SkAtomic.h
5 years, 2 months ago (2015-09-29 16:26:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373253003/1
5 years, 2 months ago (2015-09-29 16:26:51 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-09-29 16:26:52 UTC) #5
mtklein_C
lgtm
5 years, 2 months ago (2015-09-29 16:35:44 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 16:38:06 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b906daf112416c1698a79cf51aa70fe11aa19d0a

Powered by Google App Engine
This is Rietveld 408576698