Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1373133004: Fixes and add smoke test: hard timeout on isolated task. (Closed)

Created:
5 years, 2 months ago by M-A Ruel
Modified:
5 years, 2 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Fixes and add smoke test: hard timeout on isolated task. - task_runner: Only send SIGKILL once after grace period. It would previously call kill() in a closed loop. - task_runner and bot: Reduce stdout logging, it made looking at logs much harder as the data was duplicated across stdout and the log. - local_smoke_test: Add support to leak directories in local_smoke_test. - local_smoke_test: Add two isolated tasks with hard timeout; one with and one without signal handling, to catch more corner case. This permits exhibiting a bug in the code base. - Reduce number on unnecessary try/except, subprocess42.Popen is less insane. - logging_utils: Remove confusing inheritance. R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/49696b59e73ee93a03111ef2461e2eebea7577c4

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -69 lines) Patch
M appengine/components/tool_support/local_app.py View 2 chunks +7 lines, -6 lines 0 comments Download
M appengine/swarming/local_smoke_test.py View 6 chunks +116 lines, -33 lines 0 comments Download
M appengine/swarming/swarming_bot/__main__.py View 2 chunks +0 lines, -2 lines 0 comments Download
M appengine/swarming/swarming_bot/bot_code/task_runner.py View 2 chunks +9 lines, -16 lines 0 comments Download
M appengine/swarming/tools/start_bot.py View 3 chunks +7 lines, -6 lines 0 comments Download
M appengine/swarming/tools/start_servers.py View 3 chunks +4 lines, -4 lines 0 comments Download
M client/utils/logging_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M client/utils/subprocess42.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
M-A Ruel
It's not fixing anything but document more the current behavior and adds hint to make ...
5 years, 2 months ago (2015-10-01 13:34:50 UTC) #2
Vadim Sh.
lgtm
5 years, 2 months ago (2015-10-01 17:34:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373133004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373133004/20001
5 years, 2 months ago (2015-10-01 17:48:31 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 17:51:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://github.com/luci/luci-py/commit/49696b59e73ee93a03111ef2461e2eebea7577c4

Powered by Google App Engine
This is Rietveld 408576698