Media Galleries API Extension functions: Refactor Preference initialization block.

Media Galleries API Extension functions: Refactor Preference initialization block.

This refactors some repeated code, as we're about to add a few more extension calls.

BUG=161119
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245101

[tommycli, 2014-01-13 22:36:32]

vandebo: My attempt at streamlining the repeated Preference initialization
blocks...

[vandebo (ex-Chrome), 2014-01-14 17:03:39]

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:76: bool
SetupCall(Profile* profile, std::string* error, base::Closure callback) {
nit: Initialize or Setup

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:244:
MediaGalleries::GetMediaFileSystemsInteractivity interactive =
Parameter validation should happen before RunImpl returns.

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:506: if
(!args_->Get(1, &options_value)) {
And here

[tommycli, 2014-01-14 17:42:40]

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:76: bool
SetupCall(Profile* profile, std::string* error, base::Closure callback) {
On 2014/01/14 17:03:39, vandebo wrote:
> nit: Initialize or Setup

Done.

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:244:
MediaGalleries::GetMediaFileSystemsInteractivity interactive =
On 2014/01/14 17:03:39, vandebo wrote:
> Parameter validation should happen before RunImpl returns. 

Done. By the way, since the parameter checks now occur before the
ApiIsAccessible check, if we have both an inaccessible API AND invalid
parameters, the error returned will be different with this change.

If that's not acceptable, I'm not sure we can do much cleanup here...

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:506: if
(!args_->Get(1, &options_value)) {
On 2014/01/14 17:03:39, vandebo wrote:
> And here

Done.

[vandebo (ex-Chrome), 2014-01-14 17:52:25]

LGTM

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

https://codereview.chromium.org/137313003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:244:
MediaGalleries::GetMediaFileSystemsInteractivity interactive =
On 2014/01/14 17:42:41, tommycli wrote:
> On 2014/01/14 17:03:39, vandebo wrote:
> > Parameter validation should happen before RunImpl returns. 
> 
> Done. By the way, since the parameter checks now occur before the
> ApiIsAccessible check, if we have both an inaccessible API AND invalid
> parameters, the error returned will be different with this change.
> 
> If that's not acceptable, I'm not sure we can do much cleanup here...

That seems ok since none of the parameters checks on dependent on instance
specific data.

https://codereview.chromium.org/137313003/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.h
(right):

https://codereview.chromium.org/137313003/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/media_galleries/media_galleries_api.h:37:
MediaGalleries::GetMediaFileSystemsInteractivity interactive);
nit spaces

[tommycli, 2014-01-14 18:32:47]

https://codereview.chromium.org/137313003/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.h
(right):

https://codereview.chromium.org/137313003/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/media_galleries/media_galleries_api.h:37:
MediaGalleries::GetMediaFileSystemsInteractivity interactive);
On 2014/01/14 17:52:25, vandebo wrote:
> nit spaces

I think the change is to the preferred style.

[vandebo (ex-Chrome), 2014-01-14 18:34:09]

https://codereview.chromium.org/137313003/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.h
(right):

https://codereview.chromium.org/137313003/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/media_galleries/media_galleries_api.h:37:
MediaGalleries::GetMediaFileSystemsInteractivity interactive);
On 2014/01/14 18:32:48, tommycli wrote:
> On 2014/01/14 17:52:25, vandebo wrote:
> > nit spaces
> 
> I think the change is to the preferred style.

Der - your right.  nevermind.

[commit-bot: I haz the power, 2014-01-14 18:54:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/137313003/80001

[commit-bot: I haz the power, 2014-01-14 23:26:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/137313003/80001

[commit-bot: I haz the power, 2014-01-15 03:03:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/137313003/80001

[commit-bot: I haz the power, 2014-01-16 03:48:40]

Change committed as 245101