Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 137313002: Annotate mapped memory regions for LeakSanitizer. (Closed)

Created:
6 years, 11 months ago by earthdok
Modified:
6 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Annotate mapped memory regions for LeakSanitizer. Add in-code annotations for LeakSanitizer to treat any memory allocated through the VirtualMemory class as a source of live pointers. This change eliminates false positive leak reports when running Chromium under LSan. BUG=chromium:328552 R=mstarzinger@chromium.org LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=18589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/platform-linux.cc View 4 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
Please take a look. With the lastest clang roll in Chromium we can finally commit ...
6 years, 11 months ago (2014-01-13 20:24:29 UTC) #1
Michael Starzinger
LGTM. I will land this.
6 years, 11 months ago (2014-01-14 13:37:45 UTC) #2
earthdok
On 2014/01/14 13:37:45, Michael Starzinger wrote: > LGTM. I will land this. Thanks!
6 years, 11 months ago (2014-01-14 13:47:38 UTC) #3
Michael Starzinger
6 years, 11 months ago (2014-01-14 14:00:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18589 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698