Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1373103002: Unbreak gn build of net_unittests on Android (Closed)

Created:
5 years, 2 months ago by asanka
Modified:
5 years, 2 months ago
Reviewers:
xunjieli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unbreak gn build of net_unittests on Android /net/test/run_all_unittests.cc references url::android::RegisterJni which is defined in url/android/url_jni_registrar.h. url/BUILD.gn only includes the latter when building url_lib_use_icu_alternatives_on_android, but not when building url_lib. Conditionalize the use of url::android::RegisterJni so that it's only invoked when USE_ICU_ALTERNATIVE_ON_ANDROID is defined. I.e. Only use url::android::RegisterJni when the current build target is depending on url_lib_use_icu_alternatives_on_android. BUG=none Committed: https://crrev.com/ca61186fc5e11cc2acb59c3d2f28016f246ce807 Cr-Commit-Position: refs/heads/master@{#351387}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M components/cronet/android/cronet_library_loader.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M net/test/run_all_unittests.cc View 1 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
asanka
PTAL?
5 years, 2 months ago (2015-09-29 18:16:31 UTC) #4
xunjieli
On 2015/09/29 18:16:31, asanka wrote: > PTAL? The change makes sense. LGTM. Thanks!
5 years, 2 months ago (2015-09-29 18:20:46 UTC) #5
asanka
On 2015/09/29 at 18:20:46, xunjieli wrote: > On 2015/09/29 18:16:31, asanka wrote: > > PTAL? ...
5 years, 2 months ago (2015-09-29 20:19:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373103002/20001
5 years, 2 months ago (2015-09-29 20:20:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 20:26:45 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 20:27:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca61186fc5e11cc2acb59c3d2f28016f246ce807
Cr-Commit-Position: refs/heads/master@{#351387}

Powered by Google App Engine
This is Rietveld 408576698