Chromium Code Reviews
DescriptionUnbreak gn build of net_unittests on Android
/net/test/run_all_unittests.cc references url::android::RegisterJni
which is defined in url/android/url_jni_registrar.h. url/BUILD.gn only
includes the latter when building
url_lib_use_icu_alternatives_on_android, but not when building url_lib.
Conditionalize the use of url::android::RegisterJni so that it's only
invoked when USE_ICU_ALTERNATIVE_ON_ANDROID is defined. I.e. Only use
url::android::RegisterJni when the current build target is depending on
url_lib_use_icu_alternatives_on_android.
BUG=none
Committed: https://crrev.com/ca61186fc5e11cc2acb59c3d2f28016f246ce807
Cr-Commit-Position: refs/heads/master@{#351387}
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 10 (4 generated)
|
||||||||||||||||||||||||||||