[chromium-reviews] Add "Enable spell check for this field" menu option in sub context menu for c...

Add "Enable spell check for this field" menu option in sub context menu for context menu over text box, and deploy its functionality accordingly across the code. This patch also allows manual switch-on of spell check in single line text box fields.

[sidchat (Google), 2008-12-11 01:56:42]

Glen, could you please review the render view context menu parts, and the chrome
dll resource part.

Brett, could you please review the rest of the spellchecker part.

[brettw, 2008-12-11 02:29:11]

http://codereview.chromium.org/13731/diff/17/217
File webkit/glue/editor_client_impl.h (right):

http://codereview.chromium.org/13731/diff/17/217#newcode142
Line 142: // turned off. The default setting is true.
I think this is not exactly correct. We currently have logic that doesn't
spellcheck single line text fields. We should remove this in lieu of your new
flag, and default the flag's value to false if the text field is single line.
This allows user the ability to still turn it on if they want for single-line
fields.

[sidchat (Google), 2008-12-12 17:06:59]

Great suggestions. I made changes accordingly. isContinuosSpellcheckingEnabled()
now returns true or false according 
to the logic for single line spell check. Thus, the new changes disable spell
check in the context menu by default for single line text boxes - the user can
force it on, which enables spell checking in  single line text boxes. 

Please have a look again.

-Sid

On 2008/12/11 02:29:11, brettw wrote:
> http://codereview.chromium.org/13731/diff/17/217
> File webkit/glue/editor_client_impl.h (right):
> 
> http://codereview.chromium.org/13731/diff/17/217#newcode142
> Line 142: // turned off. The default setting is true.
> I think this is not exactly correct. We currently have logic that doesn't
> spellcheck single line text fields. We should remove this in lieu of your new
> flag, and default the flag's value to false if the text field is single line.
> This allows user the ability to still turn it on if they want for single-line
> fields.

[brettw, 2008-12-12 18:00:01]

I don't think we need FocusedFrameNeedsSpellchecking in WebView anymore. Can
this logic be moved to the editor client and renamed to
ShouldSpellcheckByDefault() or something like that.

[sidchat (Google), 2008-12-12 19:09:52]

Made changes as per your suggestions. Please have a look again.

-Sid

On 2008/12/12 18:00:01, brettw wrote:
> I don't think we need FocusedFrameNeedsSpellchecking in WebView anymore. Can
> this logic be moved to the editor client and renamed to
> ShouldSpellcheckByDefault() or something like that.

[brettw, 2008-12-12 19:12:37]

LGTM

http://codereview.chromium.org/13731/diff/406/411
File webkit/glue/editor_client_impl.cc (right):

http://codereview.chromium.org/13731/diff/406/411#newcode117
Line 117: bool EditorClientImpl::ShouldSpellcheckByDefault() {
Is it possible to make this function const? If so, do it, otherwise don't worry
about it.

[Glen Murphy, 2008-12-12 19:22:01]

Frontend changes LGTM