Issue 137303004: Remove isRenderSVGBlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137303004: Remove isRenderSVGBlock (Closed)

Created:
6 years, 11 months ago by rwlbuis

Modified:
6 years, 11 months ago

Reviewers:
pdr.

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove isRenderSVGBlock It is only used once and can be replaced by using isSVG(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165018

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -3 lines)			Patch
M	Source/core/rendering/RenderBoxModelObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/svg/RenderSVGBlock.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pdr.

On 2014/01/13 22:10:50, rwlbuis wrote: > A straightforward patch, hopefully :) LGTM

6 years, 11 months ago (2014-01-13 22:12:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/137303004/1

6 years, 11 months ago (2014-01-13 22:19:29 UTC) #3

Message was sent while issue was closed.

Change committed as 165018

Expand Messages | Collapse Messages