Issue 137303002: Fix Glib flag in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137303002: Fix Glib flag in GN build. (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix Glib flag in GN build. It had an extra underscore at the beginning. R=thakis@chromium.org TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244595

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/config/compiler/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Nico

lgtm When moving stuff from gyp to gn, we should always verify that the built ...

6 years, 11 months ago (2014-01-13 20:21:53 UTC) #2

brettw

6 years, 11 months ago (2014-01-13 22:12:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r244595 (presubmit successful).