third_party/WebKit/Source/modules/mediastream/RTCCertificate.idl - Issue 1373023002: RTCCertificate, RTCPeerConnection.generateCertificate (WebRTC JavaScript) added.

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCCertificate.idl

Issue 1373023002: RTCCertificate, RTCPeerConnection.generateCertificate (WebRTC JavaScript) added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make trybots compile (WebRTCCertificate not including wtf/Noncopyable) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/mediastream/RTCCertificate.h ('K') | « third_party/WebKit/Source/modules/mediastream/RTCCertificate.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h » ('j') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCCertificate.idl

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionCallback.idl b/third_party/WebKit/Source/modules/mediastream/RTCCertificate.idl

similarity index 83%

copy from third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionCallback.idl

copy to third_party/WebKit/Source/modules/mediastream/RTCCertificate.idl

index 59ffe441a6758bedde67a1101efbb550a921affc..d4fc076809c617f48f7a12c76600c2a7fad45ab8 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionCallback.idl

+++ b/third_party/WebKit/Source/modules/mediastream/RTCCertificate.idl

@@ -1,5 +1,5 @@

* Redistribution and use in source and binary forms, with or without

* modification, are permitted provided that the following conditions

@@ -28,7 +28,12 @@

* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-callback interface RTCSessionDescriptionCallback {

- void handleEvent(RTCSessionDescription sdp);

philipj_slow 2015/10/08 08:32:31 Can you link to http://w3c.github.io/webrtc-pc/#rt

hbos_chromium 2015/10/14 13:00:50 Done.

+ GarbageCollected,

+ NoInterfaceObject,

philipj_slow 2015/10/08 08:32:31 The spec doesn't have [NoInterfaceObject].

hbos_chromium 2015/10/14 13:00:50 Done. Nice catch.

+ RuntimeEnabled=RTCCertificate

+] interface RTCCertificate {

+ // The date and time after which the certificate should be considered

+ // invalid.

+ readonly attribute Date expires;

philipj_slow 2015/10/08 08:32:31 I've filed a spec bug here: https://github.com/w3c

hbos_chromium 2015/10/14 13:00:50 You're right, that's kind of blargh. cert.expires

philipj_slow 2015/10/16 13:32:31 Given that this is behind a flag I think this does

hbos_chromium 2015/10/19 15:21:35 The spec bug discussion has changed, right now it

};