RTCCertificate, RTCPeerConnection.generateCertificate (WebRTC JavaScript) added.

third_party/WebKit/public/platform/WebRTCCertificate.h

 /*
- * Copyright (c) 2012, Google Inc. All rights reserved.
+ * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef HTMLTemplateElement_h
-#define HTMLTemplateElement_h
+#ifndef WebRTCCertificate_h
+#define WebRTCCertificate_h
 
-#include "core/html/HTMLElement.h"
+#include "public/platform/WebRTCKeyParams.h"
+
+namespace rtc {
+class RTCCertificate;
+template<class T>
+class scoped_refptr;
+}
 
 namespace blink {
 
-class DocumentFragment;
-class TemplateContentDocumentFragment;
+// Interface defining what blink needs to know about certificates (abstracting away

[Ryan Sleevi, 2015/10/10 04:04:48]

comment nit: Shouldn't this be Blink?

[hbos_chromium, 2015/10/14 13:00:50]

Done.

+// Chromium and WebRTC layer implementation details). You can create shallow copies of the

[Ryan Sleevi, 2015/10/10 04:04:48]

This doesn't seem like proper grammar, nor in line with our comment styles. It
seems colloquial, but also "abstracting way" should be "abstracting away"

[hbos_chromium, 2015/10/14 13:00:50]

Acknowledged.

+// WebRTCCertificate. When all copies are destroyed, the implementation-specific data must
+// be freed. WebRTCCertificate objects thus act like references to the reference counted
+// internal data.
+class WebRTCCertificate {
+public:
+    WebRTCCertificate() = default;
+    virtual ~WebRTCCertificate() = default;
 
-class HTMLTemplateElement final : public HTMLElement {
-    DEFINE_WRAPPERTYPEINFO();
-public:
-    DECLARE_NODE_FACTORY(HTMLTemplateElement);
-    ~HTMLTemplateElement() override;
-    DECLARE_VIRTUAL_TRACE();
+    // Copies the WebRTCCertificate object without copying the underlying
+    // implementation-specific (WebRTC layer) certificate. When all copies are destroyed
+    // the underlying data is freed.
+    virtual WebRTCCertificate* shallowCopy() const = 0;
 
-    DocumentFragment* content() const;
+    virtual const WebRTCKeyParams& keyParams() const = 0;
+
+    // The date and time after which the certificate should be considered
+    // invalid. Expressed in time since 1970-01-01T00:00:00Z in milliseconds.
+    virtual double expires() const = 0;
+
+    // Gets a raw pointer to a member value referencing the WebRTC layer version

[Guido Urdaneta, 2015/10/08 11:13:03]

s/Gets/Returns

[hbos_chromium, 2015/10/14 13:00:50]

Done.

+    // of the certificate. Using pointers because the blink layer does not have
+    // knowledge of the WebRTC class implementations.
+    virtual const rtc::scoped_refptr<rtc::RTCCertificate>* rtcCertificate() const = 0;

[Guido Urdaneta, 2015/10/08 11:13:03]

What if you return constant ref instead of constant pointer?

[hbos_chromium, 2015/10/14 13:00:50]

Done. Yeah that feels better!

 
 private:
-    PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) override;
-    void didMoveToNewDocument(Document& oldDocument) override;
-
-    explicit HTMLTemplateElement(Document&);
-
-    mutable RefPtrWillBeMember<TemplateContentDocumentFragment> m_content;
+    WebRTCCertificate(const WebRTCCertificate&) = delete;
+    WebRTCCertificate& operator=(const WebRTCCertificate&) = delete;

[hbos_chromium, 2015/10/06 15:56:35]

The include of wtf/Noncopyable caused problems when compiling with GN (file not
found), but not when compiling with gyp. I don't know if public/platform should
or should not have a dependency on wtf or, if it should, how I need to updated
the GN files. I spent some time on this already and then finally removed the
include, but if this file should use WTF_MAKE_NONCOPYABLE I need to look at this
even more. Reviewers?

 };
 
 } // namespace blink
 
-#endif // HTMLTemplateElement_h
+#endif // WebRTCCertificate_h