RTCCertificate, RTCPeerConnection.generateCertificate (WebRTC JavaScript) added.

content/renderer/media/rtc_certificate.h

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_MEDIA_RTC_CERTIFICATE_H_
+#define CONTENT_RENDERER_MEDIA_RTC_CERTIFICATE_H_
+
+#include "base/macros.h"
+#include "third_party/WebKit/public/platform/WebRTCCertificate.h"
+#include "third_party/WebKit/public/platform/WebRTCKeyParams.h"
+#include "third_party/webrtc/base/rtccertificate.h"
+#include "third_party/webrtc/base/scoped_ref_ptr.h"
+
+namespace content {
+
+// Chromium's WebRTCCertificate implementation; wraps a rtc::scoped_refptr to an
+// rtc::RTCCertificate. This abstraction layer is necessary because blink does
+// not have direct access to the WebRTC stuff.

[Ryan Sleevi, 2015/10/10 04:04:48]

comment nit: "stuff" seems a bit... colloquial

[hbos_chromium, 2015/10/14 13:00:49]

Done.

+class RTCCertificate : public blink::WebRTCCertificate {
+ public:
+  RTCCertificate(const blink::WebRTCKeyParams& key_params,
+                 const rtc::scoped_refptr<rtc::RTCCertificate>& certificate);
+  ~RTCCertificate() override;
+
+  RTCCertificate* shallowCopy() const override;
+  const blink::WebRTCKeyParams& keyParams() const override;
+  double expires() const override;
+
+  const rtc::scoped_refptr<rtc::RTCCertificate>*

[Ryan Sleevi, 2015/10/10 04:04:48]

Why are you returning a pointer to a scoped pointer?

[hbos_chromium, 2015/10/14 13:00:49]

The interface being implemented, blink::WebRTCCertificate, exists in blink which
does not "know" about webrtc code. I cannot return by value without introducing
a real dependency on webrtc from blink which is not allowed.

I resorted to returning a const ptr to the raw member data. This would otherwise
be bad practice, but I think it is an acceptable solution considering
alternatives (such as static_casting from blink interface to chromium
implementation with hidden assumptions about which implementation is used).

On second thought I'll return const reference instead of const pointer. Similar
but better style.

+  rtcCertificate() const override;
+
+ private:
+  blink::WebRTCKeyParams key_params_;
+  rtc::scoped_refptr<rtc::RTCCertificate> certificate_;
+
+  DISALLOW_COPY_AND_ASSIGN(RTCCertificate);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_RENDERER_MEDIA_RTC_CERTIFICATE_H_