runtime/vm/flow_graph_compiler_mips.cc - Issue 1373013002: VM: Fix bug in the new edge counter code on ARM and MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 1373013002: VM: Fix bug in the new edge counter code on ARM and MIPS. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_mips.cc

diff --git a/runtime/vm/flow_graph_compiler_mips.cc b/runtime/vm/flow_graph_compiler_mips.cc

index 05cbcc0a9a09295f54d76494fdd96403b0c31e9b..1496565a217c6e2d7f8aefb74ff53cb245cff86a 100644

--- a/runtime/vm/flow_graph_compiler_mips.cc

+++ b/runtime/vm/flow_graph_compiler_mips.cc

@@ -1207,9 +1207,9 @@ void FlowGraphCompiler::EmitEdgeCounter(intptr_t edge_id) {

ASSERT(!edge_counters_array_.IsNull());

__ Comment("Edge counter");

__ LoadObject(T0, edge_counters_array_);

- __ lw(T1, FieldAddress(T0, Array::element_offset(edge_id)));

+ __ LoadFieldFromOffset(T1, T0, Array::element_offset(edge_id));

__ AddImmediate(T1, T1, Smi::RawValue(1));

- __ sw(T1, FieldAddress(T0, Array::element_offset(edge_id)));

+ __ StoreFieldToOffset(T1, T0, Array::element_offset(edge_id));

}