html_viewer/Mandoline: Avoid subclassing WebLayerImpl

html_viewer/Mandoline: Avoid subclassing WebLayerImpl

cc/blink will go away eventually with the repo merge. We should avoid
subclassing from there as per danakj@'s suggestion.

BUG=none

Committed: https://crrev.com/7fbb03268484ae777c1338529bfaf266aa712732
Cr-Commit-Position: refs/heads/master@{#351136}

[Fady Samuel, 2015-09-28 15:08:48]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-09-28 15:29:09]

https://codereview.chromium.org/1373003002/diff/1/components/html_viewer/html...
File components/html_viewer/html_frame.cc (right):

https://codereview.chromium.org/1373003002/diff/1/components/html_viewer/html...
components/html_viewer/html_frame.cc:589: frame_size_in_pixels_);
Why do we need frame_size_in_pixels_ as a member? Could this line change to get
the size from the view_ ? In fact could we always get the size from the view?
Shouldn't the view be resized by the owner to the right size?

[Fady Samuel, 2015-09-28 15:57:01]

PTAL Scott! Thanks!

https://codereview.chromium.org/1373003002/diff/1/components/html_viewer/html...
File components/html_viewer/html_frame.cc (right):

https://codereview.chromium.org/1373003002/diff/1/components/html_viewer/html...
components/html_viewer/html_frame.cc:589: frame_size_in_pixels_);
On 2015/09/28 15:29:09, sky wrote:
> Why do we need frame_size_in_pixels_ as a member? Could this line change to
get
> the size from the view_ ? In fact could we always get the size from the view?
> Shouldn't the view be resized by the owner to the right size?

Done.

[sky, 2015-09-28 17:58:13]

https://codereview.chromium.org/1373003002/diff/20001/components/html_viewer/...
File components/html_viewer/html_frame.cc (right):

https://codereview.chromium.org/1373003002/diff/20001/components/html_viewer/...
components/html_viewer/html_frame.cc:891:
owned_view_->view()->SetBounds(*mojo_rect_in_pixels);
Is this code path only hit if owned_view_ is non-null?

[Fady Samuel, 2015-09-28 18:35:24]

PTAL

https://codereview.chromium.org/1373003002/diff/20001/components/html_viewer/...
File components/html_viewer/html_frame.cc (right):

https://codereview.chromium.org/1373003002/diff/20001/components/html_viewer/...
components/html_viewer/html_frame.cc:891:
owned_view_->view()->SetBounds(*mojo_rect_in_pixels);
On 2015/09/28 17:58:13, sky wrote:
> Is this code path only hit if owned_view_ is non-null?

Yes. Added a guard.

[sky, 2015-09-28 19:11:45]

LGTM

[Fady Samuel, 2015-09-28 19:12:18]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-09-28 19:14:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373003002/40001

[commit-bot: I haz the power, 2015-09-28 20:54:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-28 20:55:00]

Patchset 3 (id:??) landed as
https://crrev.com/7fbb03268484ae777c1338529bfaf266aa712732
Cr-Commit-Position: refs/heads/master@{#351136}