[Android] Add OWNERS file for build/android/pylib

[Android] Add OWNERS file for build/android/pylib

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193446

[frankf, 2013-04-05 23:13:52]

I know there was some opposition in the past about OWNERS file. But, we've spend
quite a bit of time refactoring pylib (crbug.com/167331). We're not there yet,
but we've made a lot of progress and it's time to enforce stricter code reviews
to maintain the quality.

[Isaac (away), 2013-04-06 01:28:54]

+nilesh, cmp

I like the idea of an OWNERS file here, but I'm unsold about 'set noparent'.  I
think of build/android/buildbot as an exception and not the rule. There have
been initiatives to remove the directive from src entirely (crrev.com/11191038).

Some reasons we added noparent for build/android/buildbot:
- to limit churn and encourage changes in pylib instead of buildbot
- buildbot changes can have serious implications for overall state of the tree
and for CQ/lkgr, something that often only the chrome-infrastructure-team can
fix. 
- I see build/android/buildbot as a convenience location which is more typically
in the tools/build repo that is governed by a separate OWNERS file.

[nilesh, 2013-04-06 04:41:50]

On 2013/04/06 01:28:54, Isaac wrote:
> +nilesh, cmp
> 
> I like the idea of an OWNERS file here, but I'm unsold about 'set noparent'. 
I
> think of build/android/buildbot as an exception and not the rule. There have
> been initiatives to remove the directive from src entirely
(crrev.com/11191038).
> 
> Some reasons we added noparent for build/android/buildbot:
> - to limit churn and encourage changes in pylib instead of buildbot
> - buildbot changes can have serious implications for overall state of the tree
> and for CQ/lkgr, something that often only the chrome-infrastructure-team can
> fix. 
> - I see build/android/buildbot as a convenience location which is more
typically
> in the tools/build repo that is governed by a separate OWNERS file.

If you go ahead with this, please add a separate OWNERS file for
build/android/pylib/gtest/filter/

We should have a more inclusive build/android/OWNERS in addition to this.
Also we can start without 'set noparent' and see if this is a problem.  You are
supposed to get approval from the closest OWNERS anyway.

[frankf, 2013-04-08 23:48:31]

PTAL.

Agree that we should try without 'set noparent' and see how it goes.

On 2013/04/06 04:41:50, nilesh wrote:
> On 2013/04/06 01:28:54, Isaac wrote:
> > +nilesh, cmp
> > 
> > I like the idea of an OWNERS file here, but I'm unsold about 'set noparent'.

> I
> > think of build/android/buildbot as an exception and not the rule. There have
> > been initiatives to remove the directive from src entirely
> (crrev.com/11191038).
> > 
> > Some reasons we added noparent for build/android/buildbot:
> > - to limit churn and encourage changes in pylib instead of buildbot
> > - buildbot changes can have serious implications for overall state of the
tree
> > and for CQ/lkgr, something that often only the chrome-infrastructure-team
can
> > fix. 
> > - I see build/android/buildbot as a convenience location which is more
> typically
> > in the tools/build repo that is governed by a separate OWNERS file.
> 
> If you go ahead with this, please add a separate OWNERS file for
> build/android/pylib/gtest/filter/
> 
> We should have a more inclusive build/android/OWNERS in addition to this.
> Also we can start without 'set noparent' and see if this is a problem.  You
are
> supposed to get approval from the closest OWNERS anyway.

[craigdh, 2013-04-08 23:55:12]

lgtm.

[bulach, 2013-04-09 09:37:33]

lgtm

[frankf, 2013-04-10 20:29:57]

Committed patchset #2 manually as r193446 (presubmit successful).