Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 13730011: add 'Aura' to version if USE_AURA on windows (Closed)

Created:
7 years, 8 months ago by scottmg
Modified:
7 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews
Visibility:
Public.

Description

add 'Aura' to version if USE_AURA on windows R=cpu@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192832

Patch Set 1 #

Total comments: 1

Patch Set 2 : don't change chromium path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/common/chrome_version_info_win.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cpu_(ooo_6.6-7.5)
lgtm
7 years, 8 months ago (2013-04-05 20:50:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/13730011/1
7 years, 8 months ago (2013-04-05 20:50:36 UTC) #2
commit-bot: I haz the power
Presubmit check for 13730011-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-05 20:50:38 UTC) #3
scottmg
+jam for owners
7 years, 8 months ago (2013-04-06 00:18:02 UTC) #4
jam
https://codereview.chromium.org/13730011/diff/1/chrome/common/chrome_version_info_win.cc File chrome/common/chrome_version_info_win.cc (right): https://codereview.chromium.org/13730011/diff/1/chrome/common/chrome_version_info_win.cc#newcode33 chrome/common/chrome_version_info_win.cc:33: #if defined(USE_AURA) do you really need to change the ...
7 years, 8 months ago (2013-04-08 15:32:09 UTC) #5
scottmg
On 2013/04/08 15:32:09, jam wrote: > https://codereview.chromium.org/13730011/diff/1/chrome/common/chrome_version_info_win.cc > File chrome/common/chrome_version_info_win.cc (right): > > https://codereview.chromium.org/13730011/diff/1/chrome/common/chrome_version_info_win.cc#newcode33 > ...
7 years, 8 months ago (2013-04-08 16:25:20 UTC) #6
jam
lgtm On 2013/04/08 16:25:20, scottmg wrote: > On 2013/04/08 15:32:09, jam wrote: > > > ...
7 years, 8 months ago (2013-04-08 16:53:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/13730011/7001
7 years, 8 months ago (2013-04-08 16:59:59 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 17:08:42 UTC) #9
scottmg
7 years, 8 months ago (2013-04-08 18:05:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r192832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698