Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: grit/format/policy_templates/writers/template_writer.py

Issue 1372953002: Add support for the 'webview_android' policy configuration (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master
Patch Set: Address comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « grit/format/policy_templates/writers/doc_writer_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit/format/policy_templates/writers/template_writer.py
diff --git a/grit/format/policy_templates/writers/template_writer.py b/grit/format/policy_templates/writers/template_writer.py
index d489d648c3767e9a1d94e57e851745abf52b4d76..4a6b77b481e913556760aa4bf1ee5006d21b6222 100644
--- a/grit/format/policy_templates/writers/template_writer.py
+++ b/grit/format/policy_templates/writers/template_writer.py
@@ -91,15 +91,20 @@ class TemplateWriter(object):
'''Checks if the given policy can be mandatory.'''
return policy.get('features', {}).get('can_be_mandatory', True)
- def IsPolicySupportedOnPlatform(self, policy, platform):
- '''Checks if |policy| is supported on |platform|.
+ def IsPolicySupportedOnPlatform(self, policy, platform, product=None):
+ '''Checks if |policy| is supported on |product| for |platform|. If not
+ specified, only the platform support is checked.
Args:
policy: The dictionary of the policy.
platform: The platform to check; one of 'win', 'mac', 'linux' or
'chrome_os'.
+ product: Optional product to check; one of 'chrome', 'chrome_frame',
+ 'chrome_os', 'webview'
'''
- is_supported = lambda x: platform in x['platforms']
+ is_supported = lambda x: (platform in x['platforms'] and
+ (not product or product in x['product']))
+
return any(filter(is_supported, policy['supported_on']))
def _GetChromiumVersionString(self):
« no previous file with comments | « grit/format/policy_templates/writers/doc_writer_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698