Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1372923002: Revert of Re-enabling 720p WebRTC video quality test. (Closed)

Created:
5 years, 2 months ago by phoglund_chromium
Modified:
5 years, 2 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enabling 720p WebRTC video quality test. (patchset #2 id:20001 of https://codereview.chromium.org/1367453002/ ) Reason for revert: Still too slow for one of our win7 bots. Original issue's description: > Re-enabling 720p WebRTC video quality test. > > Closing the local streams seems to solve the buffer thrashing that's > going on while gathering frames; this should stop the test from > timing out on Windows. > > BUG=532918, webrtc:4986 > > Committed: https://crrev.com/5743af3d0c098fa86f587269519e226ecce185e4 > Cr-Commit-Position: refs/heads/master@{#351034} TBR=perkj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=532918, webrtc:4986 Committed: https://crrev.com/f838038bfe998af36ffd03b0b977650dddba1cf1 Cr-Commit-Position: refs/heads/master@{#351057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of Re-enabling 720p WebRTC video quality test.
5 years, 2 months ago (2015-09-28 12:10:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372923002/1
5 years, 2 months ago (2015-09-28 12:10:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 12:10:54 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 12:11:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f838038bfe998af36ffd03b0b977650dddba1cf1
Cr-Commit-Position: refs/heads/master@{#351057}

Powered by Google App Engine
This is Rietveld 408576698